Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 1155::uri, nameregistry short names #143

Closed
4 tasks done
Tracked by #75
benjaminbollen opened this issue Apr 17, 2024 · 1 comment · Fixed by #144
Closed
4 tasks done
Tracked by #75

fix 1155::uri, nameregistry short names #143

benjaminbollen opened this issue Apr 17, 2024 · 1 comment · Fixed by #144

Comments

@benjaminbollen
Copy link
Member

benjaminbollen commented Apr 17, 2024 •
edited
Loading

  • complete ERC1155 URI with IPFS cidv0, use gateway URL as URI, instead store metadata sha256 digest in nameregistry
  • evaluate if name, symbol for hub itself can fit in 24,5 kB by storing name in namereg and calling removed it again to make space for priorities, add later possibly
  • short names are padded to fixed length 12 base58 characters
  • test short names, base58, URI metadata
@benjaminbollen benjaminbollen mentioned this issue Apr 17, 2024
Closed
28 tasks
@benjaminbollen benjaminbollen moved this to 😅In Progress in circles-contracts-v2 Apr 17, 2024
@benjaminbollen benjaminbollen mentioned this issue May 2, 2024
Merged
3 tasks
@benjaminbollen benjaminbollen moved this from 😅In Progress to 🧐Review in circles-contracts-v2 May 2, 2024
@benjaminbollen benjaminbollen linked a pull request May 2, 2024 that will close this issue
20240417 uri, base58 encoding, padding short names #144
Merged
3 tasks
@benjaminbollen benjaminbollen changed the title update CIDv0 in nameregistry to use base58 encoding/decoding & update ERC1155-URI fix 1155::uri, nameregistry short names May 2, 2024
@benjaminbollen
Copy link
Member Author

#145 re-opened to merge into develop

@benjaminbollen benjaminbollen moved this from 🧐Review to 💪Done in circles-contracts-v2 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
circles-contracts-v2
Status: 💪Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

20240417 uri, base58 encoding, padding short names CirclesUBI/circles-contracts-v2
1 participant
@benjaminbollen