Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

total supply for ERC1155 #134

Closed
3 tasks done
Tracked by #75
benjaminbollen opened this issue Apr 10, 2024 · 0 comments · Fixed by #136
Closed
3 tasks done
Tracked by #75

total supply for ERC1155 #134

benjaminbollen opened this issue Apr 10, 2024 · 0 comments · Fixed by #136

Comments

@benjaminbollen
Copy link
Member

benjaminbollen commented Apr 10, 2024 •
edited
Loading

  • totalSupply discounted
  • introducing totalSupply opens this metric open to manipulation with circular trust among groups, see group layering #135
  • implement name() and symbol() for Hub:ERC1155 (not part of standard by block explorers list it as "unnamed" otherwise) -- done and removed again for now for saving space in Hub.sol
@benjaminbollen benjaminbollen mentioned this issue Apr 10, 2024
Closed
28 tasks
@benjaminbollen benjaminbollen moved this to 😅In Progress in circles-contracts-v2 Apr 10, 2024
@benjaminbollen benjaminbollen linked a pull request Apr 12, 2024 that will close this issue
20240410 totalsupply and name, symbol of erc1155 #136
Merged
4 tasks
@benjaminbollen benjaminbollen mentioned this issue Apr 12, 2024
Merged
4 tasks
@benjaminbollen benjaminbollen moved this from 😅In Progress to 🧐Review in circles-contracts-v2 Apr 12, 2024
@benjaminbollen benjaminbollen moved this from 🧐Review to 🧊Ice Box in circles-contracts-v2 Apr 12, 2024
@benjaminbollen benjaminbollen moved this from 🧊Ice Box to 🧐Review in circles-contracts-v2 Apr 12, 2024
@benjaminbollen benjaminbollen moved this from 🧐Review to 🧊Ice Box in circles-contracts-v2 Apr 12, 2024
@benjaminbollen benjaminbollen moved this from 🧊Ice Box to 🧐Review in circles-contracts-v2 May 2, 2024
@github-project-automation github-project-automation bot moved this from 🧐Review to 💪Done in circles-contracts-v2 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
circles-contracts-v2
Status: 💪Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

20240410 totalsupply and name, symbol of erc1155 CirclesUBI/circles-contracts-v2
1 participant
@benjaminbollen