Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Ability to approve circleci jobs #58

Open
1 task done
benatshippabo opened this issue May 19, 2023 · 1 comment
Open
1 task done

Request: Ability to approve circleci jobs #58

benatshippabo opened this issue May 19, 2023 · 1 comment

Comments

@benatshippabo
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

No response

Describe the solution you'd like

Can we also have the ability to auto approve workflows based on github events as well? For example, we have the following workflow:

workflows:
  version: 2
  build:
    jobs:
      - server_unit_tests
      - server_integration_test
      - frontend_tests
      - e2e_tests_trigger:
          type: approval
      - e2e_tests:
          requires:
            - e2e_tests_trigger

Instead of triggering the pipeline, can we also have this action auto approve based on github actions? My goal is to have the job auto approve based on a label merge

Teachability, documentation, adoption, migration strategy

on:
  pull_request:
    types: [labeled]
jobs:
  trigger-circleci:
    if: ${{ github.event.label.name == 'merge' }}
    runs-on: ubuntu-latest
    steps:
      - name: <customize name>
        id: <customize id>
        uses: CircleCI-Public/[email protected]
        with:
          - APPROVAL_TRIGGER=e2e_tests_trigger
        env:
          CCI_TOKEN: ${{ secrets.CCI_TOKEN }}

What is the motivation / use case for changing the behavior?

Need a way for merge queues to be able to auto trigger circleci approval jobs

@servercimen
Copy link

We have the same need, it would be awesome to have this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants