Change install-packages include-branch-in-cache-key default to false

[blimmer]

Describe Request:

Today, the cache key for install-packages includes the branch name in the cache key by default:

node-orb/src/commands/install-packages.yml

Lines 48 to 52 in ab05d0e

	include-branch-in-cache-key:
	type: boolean
	default: true
	description: >
	If true, this cache bucket will only apply to jobs within the same branch.

This causes far more cache misses than necessary, IMO, especially because the lockfile hash is already included in the key.

I propose we change the default from true to false in the next major release. This will significantly improve user experience by reducing runtimes.

[ssunday]

Very much agree!

[Peter-Darton-i2]

I was really confused about why I wasn't getting any caching on each new PR until I found this.

If there are security concerns about cross-branch data leakage then they ought to be documented.
If not, the default should be changed.

[marboledacci]

There isn't any problem with changing the default to false for this.
We have some changes to do for the cache on this orb, this included. But they are low priority for now as the same result can be obtain updating the parameters of the command.