fix: azp: required number parameter (#251)

* seen in the azure pipelines agent ci
ChristopherHX · Oct 29, 2023 · 3feb671 · 3feb671
1 parent e269fd6
commit 3feb671
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/Sdk/AzurePipelines/AzureDevops.cs b/src/Sdk/AzurePipelines/AzureDevops.cs
@@ -560,7 +560,7 @@ public static async Task<MappingToken> ReadTemplate(Runner.Server.Azure.Devops.C
                     templateContext.Error(sparameters, "A value for the 'name' parameter must be provided.");
                     continue;
                 }
-                var defCtxData = await ConvertValue(context, def, type, values);
+                var defCtxData = def == null ? null : await ConvertValue(context, def, type, values);
                 if(cparameters?.TryGetValue(name, out var value) == true || def == null && (value = await (context.RequiredParametersProvider?.GetRequiredParameter(name) ?? Task.FromResult<TemplateToken>(null))) != null) {
                     parametersData[name] = await ConvertValue(context, value, type, values);
                 } else {

diff --git a/testworkflows/azpipelines/required-parameter-number/pipeline.yml b/testworkflows/azpipelines/required-parameter-number/pipeline.yml
@@ -0,0 +1,4 @@
+steps:
+- template: tmpl.yml
+  parameters:
+    no: 42
diff --git a/testworkflows/azpipelines/required-parameter-number/tmpl.yml b/testworkflows/azpipelines/required-parameter-number/tmpl.yml
@@ -0,0 +1,5 @@
+parameters:
+  - name: no
+    type: number
+steps:
+  - script: echo ok