Skip to content
This repository has been archived by the owner on Nov 3, 2019. It is now read-only.

Swap htmltojsx for a new library #113

Closed
simonjoom opened this issue Sep 7, 2018 · 3 comments
Closed

Swap htmltojsx for a new library #113

simonjoom opened this issue Sep 7, 2018 · 3 comments

Comments

@simonjoom
Copy link

simonjoom commented Sep 7, 2018

hi christopher

I use your plugin with success, (i should to do some hack to last gatsby to make it work else i get some trouble)

but anyway i found a problem when you pass a background image with base64 in the parser:
I found the solution that the problem was from htmltojsx and is described here.
weflex/style-parser#1

Nota htmltojsx is quite outdated and use not the last react,

Waiting answer
thanks

@ChristopherBiscardi
Copy link
Owner

Thanks for filing an issue :)

I'm going to make this an issue about upgrading to a different library to convert html to jsx. Do you have experience with the html-to-react lib you linked? Would you suggest it as a replacement?

@ChristopherBiscardi ChristopherBiscardi changed the title bug with mdx htmltojsx Swap htmltojsx for a new library Sep 7, 2018
@simonjoom
Copy link
Author

about html-to-react i tried and i did not notice improvement or something, i think htmltojsx still is the best to use for that, just he need to be updated for react16

@ChristopherBiscardi
Copy link
Owner

As of #190 we no longer use html-to-jsx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants