Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ssh functionality to screenutils #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

naarkhoo
Copy link

Running commnads on a remote server under different screen sessions. Getting list of screen sessions on a given ssh tune.

naarkhoo added 2 commits July 26, 2013 01:21
Conflicts:
	CONTRIBUTORS
	README.rst
	TODO.rst
	screenutils/screen.py
@Christophe31
Copy link
Owner

The way you commited is weird, I don't have a diff, I'll revew that later but I don't find awesome on git readability the way you started in a new repository with files copies then commit your merge.

@Christophe31
Copy link
Owner

You mix tab indent with space indent, you start contributing from an empty git repo, you introduce a new subject but don't create a file for it. I won't merge this contribution as it is.

@Christophe31
Copy link
Owner

I don't want to sound aggressive, but I think you need to improve your contribution quality standards. You also left some #~ code comment. Unused code have to be deleted, git is here to track your attempts, but preferably not in master tree.

Why do you want to manage screen over ssh? usually I don't wrap ssh cause my screenutils scripts are hosted on my servers. I may interact with them with crontabs or small sites (ex:tornado).

@naarkhoo
Copy link
Author

I see your point and your are definitely right. I am very new in github and
I am sure, I should have asked for pull when It was 100% ready. It was my
first commit and ...
but thank you for your feed back regarding my codes.

about the purpose of this development, I needed to merge session and ssh,
since, I have a computing server which I always connect via ssh to do my
stuff. If I just submit my commands (say calling a function to do some
computations for 2 days) using ssh - they would fail since the ssh tunel
terminates quickly. therefore, I used your module and execute several jobs
over ssh by running them on a screen sessions.

another example:
I have a webserver and I am developing it using Django but local. So
instead of every time login in to the server by [email protected] everytime
and running my webserver by "python manage.py runserver 8080" on a screen
session, using this module I can send my files to the server, re-run the
server engine on a screen session in 2 line code.

If you think it is relevant to you module and useful, please let me know,
then I will polish it more carefully and do what you suggested to do.
Otherwise, I put it as a separate repository,

On Mon, Jul 29, 2013 at 4:47 AM, Narbonne [email protected] wrote:

I don't want to sound aggressive, but I think you need to improve your
contribution quality standards. You also left some #~ code comment. Unused
code have to be deleted, git is here to track your attempts, but preferably
not in master tree.

Why do you want to manage screen over ssh? usually I don't wrap ssh cause
my screenutils scripts are hosted on my servers. I may interact with them
with crontabs or small sites (ex:tornado).


Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-21706522
.

@Christophe31
Copy link
Owner

In fact on both of your usecases, for me, the python script should run on the server himself. Django should run as a deamon (with autolaunch by supervisord or any other). You'll say you want to read the log: no matter, tail -f running in a screen session should be enough.

The examples I did in the doc worked for me, your comment related to a bug in the doc. If you saw a case where it didn't worked, I'm interested.

If you want to manage multiple servers from a single script, fabric can be a good choice.

It may be an interesting option, the doc is not complete enough, there are no examples on how to use your contribution.

Simply show me a snippet of usage.

@naarkhoo
Copy link
Author

naarkhoo commented Aug 1, 2013

I will make it nicer and make a test. then you can decide :-) give me sometime
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants