-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding ssh functionality to screenutils #2
base: master
Are you sure you want to change the base?
Conversation
Conflicts: CONTRIBUTORS README.rst TODO.rst screenutils/screen.py
The way you commited is weird, I don't have a diff, I'll revew that later but I don't find awesome on git readability the way you started in a new repository with files copies then commit your merge. |
You mix tab indent with space indent, you start contributing from an empty git repo, you introduce a new subject but don't create a file for it. I won't merge this contribution as it is. |
I don't want to sound aggressive, but I think you need to improve your contribution quality standards. You also left some #~ code comment. Unused code have to be deleted, git is here to track your attempts, but preferably not in master tree. Why do you want to manage screen over ssh? usually I don't wrap ssh cause my screenutils scripts are hosted on my servers. I may interact with them with crontabs or small sites (ex:tornado). |
I see your point and your are definitely right. I am very new in github and about the purpose of this development, I needed to merge session and ssh, another example: If you think it is relevant to you module and useful, please let me know, On Mon, Jul 29, 2013 at 4:47 AM, Narbonne [email protected] wrote:
|
In fact on both of your usecases, for me, the python script should run on the server himself. Django should run as a deamon (with autolaunch by supervisord or any other). You'll say you want to read the log: no matter, tail -f running in a screen session should be enough. The examples I did in the doc worked for me, your comment related to a bug in the doc. If you saw a case where it didn't worked, I'm interested. If you want to manage multiple servers from a single script, It may be an interesting option, the doc is not complete enough, there are no examples on how to use your contribution. Simply show me a snippet of usage. |
I will make it nicer and make a test. then you can decide :-) give me sometime |
Running commnads on a remote server under different screen sessions. Getting list of screen sessions on a given ssh tune.