Inspect why error no more includes a human-readable message

[malikankit]

Cross-referencing comment (3 occurences) in tests/test_multisig.py

    # TODO: Previously the error included a human-readable message, why does it
    # only include the error code now? Something to do with different Anchor
    # versions?

[ruuda]

Ah, I have a suspicion about what happened here ... I think the Anchor client might convert the error codes back to the message, and at some point maybe we switched how we call the program, so the Anchor client no longer had the opportunity to translate the error? We recently removed the Anchor client entirely, so now it’s even harder to translate it into a human-readable message ... but frankly I think these error codes are not useful, and the on-chain program should print the message to its log instead.

[ruuda]

I think it’s a problem with Anchor after all, maybe a bug introduced in a later version.

    let program_error = ProgramError::from(multisig::ErrorCode::AlreadyExecuted);
    println!("{:?}", program_error);
    let anchor_error = multisig::Error::from(program_error);
    println!("{:?}", anchor_error);

prints

Custom(105)
ProgramError(Custom(105))

while I would have expected it to print

Custom(105)
ErrorCode(AlreadyExecuted)

it seems that converting back the error code to the structured error is broken.

[ruuda]

I believe I found the cause of this: coral-xyz/anchor#354 (comment)

[ruuda]

#360 adds a workaround for this problem, so let’s close the issue.