Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.x] CapabilityContainerListener system doesn't work properly for player inventory #13

Open
Choonster opened this issue Dec 8, 2020 · 1 comment

Comments

@Choonster
Copy link
Collaborator

@Tavi007 found in this thread that the CapabilityContainerListener system doesn't properly update items in the player inventory until they're moved.

This seems to be caused by Forge patching Container#detectAndSendChanges to only call IContainerListener#sendSlotContents if a slot's Item, count or share tag has changed; which often won't be the case for capability-only updates.

This change was actually introduced in August 2017 for 1.12.2 (in MinecraftForge/MinecraftForge#4252), six months after I created my system. I thought it was working more recently than that, but I must not have tested it properly.

I need to see if there's any way around this.

@Choonster
Copy link
Collaborator Author

MinecraftForge/MinecraftForge#7630 would remove the need for this system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant