Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manningham Mills (Farbic-ASM) showing up in Mod Menu #12

Open
Eiion opened this issue Dec 2, 2021 · 5 comments
Open

Manningham Mills (Farbic-ASM) showing up in Mod Menu #12

Eiion opened this issue Dec 2, 2021 · 5 comments

Comments

@Eiion
Copy link

Eiion commented Dec 2, 2021

With Minecraft v1.18 Manningham Mills (which apparently is Farbic-ASM if I'm informed correctly) shows up in the Mod Menu causing confusion what this mod (i.e. Manningham Mills) is supposed to be when nothing like it was downloaded and put into the mods folder by the user.

Should this be a hidden mod or at least named differently so people can make a connection to it being part of OptiFabric?

(FabricMC/fabric#1876 (comment))

@Daomephsta
Copy link

Daomephsta commented Dec 2, 2021

It's not part of OptiFabric. OptiFabric bundles Fabric-ASM, but it's an independent project.
Also if you aren't already aware, there are alternatives to Optifine/OptiFabric.

@Eiion
Copy link
Author

Eiion commented Dec 2, 2021

That's what multiple people have told me on the Optifine Discord.
Also, I wasn't aware. I'll have a look at it - thanks. (The potential issue I am seeing with such alternatives is incompatibility with e.g. BSL shaders and such.)

Anyways, that doesn't solve the issue. I've never downloaded Manningham Mill, I've never put it in the mods folder - still it's there. Apparently (as I've been told) because it's part of Optifabric. It didn't show up in the versions for 1.16 nor for those of 1.17 - but does now in 1.18.

@jackassmc
Copy link

This is caused by the deprecation of the old syntax of marking mods as libraries ("modmenu:api" : true).

To mark a mod as a library in ModMenu 3+ the new syntax is:

"custom": {
    "modmenu": {
        "badges": [ "library" ]
    }
}

@AnandBhasme
Copy link

AnandBhasme commented Jan 16, 2022

So what does Manningham Mills do?
I have same problem

@Daomephsta
Copy link

So what does Manningham Mills do?
I have same problem

It's a library used by mods to alter vanilla. You have it because a mod you've installed includes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants