Update spec details, added helper init functions #18
Conversation
| @@ -167,7 +167,7 @@ public struct CompletionItem: Codable, Hashable, Sendable { | |||
| public let filterText: String? | |||
| public let insertText: String? | |||
| public let insertTextFormat: InsertTextFormat? | |||
| public let textEdit: TextEdit? | |||
| public let textEdit: TwoTypeOption<TextEdit, InsertReplaceEdit>? | |||
There was a problem hiding this comment.
| @@ -28,7 +28,7 @@ public struct InitializeParams: Codable, Hashable, Sendable { | |||
| public let workspaceFolders: [WorkspaceFolder]? | |||
|
|
|||
| public init( | |||
| processId: Int, | |||
| processId: Int?, | |||
There was a problem hiding this comment.
|
Amazing fixes! Did you find this due to language servers complaining? Two comments about the new initializers. I get what you are thinking with the Second, don't these all have the potential to create invalid |
|
I'd like to get this in. Let's get this figured out! |
|
@FastestMolasses I open this isn't too disruptive, but I wanted to accept these changes without stealing credit. To do that, but without adding the additional LSPRange API changes, I pushed to your main. I really hope this doesn't cause problems! |
Updated some fields to match the more recent spec, as well as added some helper init functions to make it easier to create LSPRanges from language server responses.