Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instead of using a bool field, expose a flags field #90

Merged
merged 1 commit into from
Nov 22, 2022
Merged

instead of using a bool field, expose a flags field #90

merged 1 commit into from
Nov 22, 2022

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 22, 2022

where one flag indicates eligible for dedup

AmineKhaldi
AmineKhaldi approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@AmineKhaldi AmineKhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@arvidn arvidn marked this pull request as ready for review November 22, 2022 12:45
@arvidn arvidn merged commit 3b3c057 into main Nov 22, 2022
@arvidn arvidn deleted the eligible-for-dedup-flags branch November 22, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @AmineKhaldi