add support for remaining primitive types to json serialization/deserialization #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
force-pushed
the
json-serialization
branch
from
da556c9
to
27e1fb6
Compare
aqk
reviewed
Nov 21, 2022
arvidn
force-pushed
the
json-serialization
branch
from
27e1fb6
to
9c82896
Compare
aqk
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there were some primitives missing, implementing the traits. This patch also makes a macro to mitigate repetition.
Additionally, another earlier oversight was to not implement the
AsReftrait forBytes(but justBytesImpl<n>). So that's also added.