Fix python fields #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
commented
Nov 18, 2022
arvidn
commented
Nov 19, 2022
…rk. Fix it and improve usability of PyStreamable macro
arvidn
force-pushed
the
fix-python-fields
branch
from
2fb1bcb
to
387dd73
Compare
aqk
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it appears the
pyo3()macro does not play well withcfg_attr(), and these members failed to be exported (and there was no test for it.This patch adds the test and works-around the issue by generating the
#[getter]functions as part of thePyStreamablemacro instead of relying onpyo3(get). This has the additional benefit to add less clutter to our class definitions.