Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release the GIL in run_block_generator() and run_block_generator2() #712

Merged
merged 1 commit into from
Sep 17, 2024
Merged

release the GIL in run_block_generator() and run_block_generator2() #712

merged 1 commit into from
Sep 17, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Sep 17, 2024 •
edited
Loading

allowing these to be run in a ThreadPoolExecutor.

This PR is best reviewed ignoring whitespaces.

@arvidn
release the GIL in run_block_generator() and run_block_generator2(), …
3b82009 
…allowing these to be run in a ThreadPoolExecutor
@arvidn arvidn marked this pull request as ready for review September 17, 2024 08:48
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 10899541656

Details

  • 38 of 46 (82.61%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 83.962%
Changes Missing Coverage Covered Lines Changed/Added Lines %
wheel/src/run_generator.rs 38 46 82.61%
Totals Coverage Status
Change from base Build 10847764096: 0.01%
Covered Lines: 12381
Relevant Lines: 14746
💛 - Coveralls

@arvidn arvidn merged commit adfc667 into main Sep 17, 2024
60 checks passed
@arvidn arvidn deleted the run-generator-release-gil branch September 17, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-o-how matt-o-how matt-o-how approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @matt-o-how