Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subclass on SpendBundle only #653

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Subclass on SpendBundle only #653

merged 2 commits into from
Aug 7, 2024

Conversation

Rigidity
Copy link
Contributor

@Rigidity Rigidity commented Aug 7, 2024 •
edited
Loading

There is a potential performance concern with subclass, so we'll enable it for SpendBundle only for now.

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Aug 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10289803494

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 81.42%
Totals Coverage Status
Change from base Build 10288538540: 0.005%
Covered Lines: 11946
Relevant Lines: 14672
💛 - Coveralls

@Rigidity Rigidity changed the title Subclass on most types Subclass on SpendBundle only Aug 7, 2024
@arvidn arvidn merged commit ad3235e into main Aug 7, 2024
59 checks passed
@arvidn arvidn deleted the subclass-v2 branch August 7, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rigidity @AmineKhaldi @arvidn