sanitize_uint improvement #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (0 in this case)
AmineKhaldi
reviewed
Mar 9, 2023
arvidn
force-pushed
the
sanitize-int
branch
2 times, most recently
from
b79fa61
to
ef1f8a8
Compare
AmineKhaldi
approved these changes
Mar 13, 2023
|
|
aqk
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch separates overflow errors from invalid integer representation errors in the
sanitize_uint()function. The overflow behaviors are almost always subject to customizations, depending on who's calling it. The invalid integer representations on the other hand, should always just propagate up.This simplifies the call sites and removes one intermediate layer of functions that currently customize the overflow behavior. Now it's done at each call site.