add support for ASSERT_MY_BIRTH_HEIGHT and ASSERT_MY_BIRTH_SECONDS #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
changed the title
arvidn
force-pushed
the
assert-my-birth
branch
2 times, most recently
from
ec1bdf7
to
00ea27f
Compare
richardkiss
reviewed
Mar 1, 2023
richardkiss
reviewed
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These conditions ensure that the coin asserting were confirmed at a specific block height, or in a block with a specific timestamp.
The condition codes are:
Since this validation can't be done in the parsing step, it's forwarded in the
Spendobject as two new optional integers.There are a few cases that need to be validated however. If the same spend asserts different heights or different timestamps, that's an immediate failure.
If the same spend asserts the same height multiple times, that's fine, we just forward that one height (or timestamp).