Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 0.2.0 #112

Merged
merged 1 commit into from
Jan 5, 2023
Merged

bump version to 0.2.0 #112

merged 1 commit into from
Jan 5, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jan 5, 2023

No description provided.

@arvidn arvidn marked this pull request as ready for review January 5, 2023 14:45
Copy link
Contributor

@ChiaMineJP ChiaMineJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm.
I've tried to build wasm but the wasm file created was only 256 bytes.
I checked wasm/src/lib.rs and found that the content was:

use wasm_bindgen::prelude::*;

#[wasm_bindgen]
pub fn a_test_function() -> u64 {
    500
}

So wasm code is not ready yet.
Do you think it blocks 0.2.0 release?

@arvidn
Copy link
Contributor Author

arvidn commented Jan 5, 2023

Missing wasm bindings is not a blocker for chia-blockchain 1.7.

I seem to recall you adding some bindings though, but perhaps that was for clvm_rs

@ChiaMineJP
Copy link
Contributor

Yes, I implemented wasm bindings for clvm_rs but not yet for chia_rs.
I agree that empty wasm doesn't block releasing.
I'll approve this PR with our conversation left here.

@richardkiss richardkiss merged commit c6126aa into main Jan 5, 2023
@richardkiss richardkiss deleted the bump-version-2.0 branch January 5, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants