Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Check remote harvester compatibility #17724

Closed
Fahrenheit2539 opened this issue Mar 18, 2024 · 3 comments
Closed

[Bug] Check remote harvester compatibility #17724

Fahrenheit2539 opened this issue Mar 18, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Fahrenheit2539
Copy link

What happened?

I was running a full 2.1.4 node with 3 remote harvesters on 2.0.0.

After upgrading to 2.2.1 all was looking good, harvesters connected, number of plots was correct. However next day I noticed that the 24-hour farm size dropped to ~50%. Reverting back to 2.1.4 on the full node helped to solve the problem, and farm size is back to normal.

Confirmed in discord that 2.2.1 indeed requires updating harvesters.

Ask is two-fold:

  1. Introduce harvester protocol versioning so if unsupported version connects this will be clearly communicated to the user. Don't think in all cases harvesters need to be on the latest version - I was (and is) successfully running 2.0.0 with 2.1.4 full node.
  2. Please clearly state in release notes minimum harvester version that'll work (or at least that update is required). I double-checked, could not find anything

Version

2.2.1

What platform are you using?

Windows

What ui mode are you using?

GUI

Relevant log output

No response

@Fahrenheit2539 Fahrenheit2539 added the bug Something isn't working label Mar 18, 2024
@felixbrucker
Copy link
Contributor

To add to that: software version and protocol version are sent in the handshake, but not evaluated/validated in chia-blockchain

For compatibility we should not check the software version (arbitrary string) but the protocol version.

Note: protocol version is global right now, in the future we might have independent protocol versions for the different protocols

@wjblanke
Copy link
Contributor

Arvid is working on separating out the versioning

#17791

@wjblanke
Copy link
Contributor

wjblanke commented Apr 3, 2024

This is improved in main due to 17791

@wjblanke wjblanke closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants