Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush log output immediately #78

Closed
altendky opened this issue Aug 29, 2021 · 4 comments
Closed

Flush log output immediately #78

altendky opened this issue Aug 29, 2021 · 4 comments

Comments

@altendky
Copy link
Contributor

I am just now getting around to trying to add BladeBit support to plotman. Generally speaking the multiple-process scheduling features of plotman should be much less useful for BladeBit, but it makes it easier for people to experiment with configurations and still handle plotting and archiving from the single tool. Anyways...

When the output of BladeBit is redirected to a file it ends up buffering until the flush at the end (well, I didn't wait that long what with only 64GB of RAM at the moment but...). plotman would like to have regular updates so that it can track the progress of the plot. With the logging functions already being centralized it looks like this could be a straightforward change.

Does this seem like a good change for BladeBit?

@harold-b
Copy link
Contributor

Nice to see you here, Kyle

Sure, @mocksoul already provided a PR for this. I merged it into the develop branch yesterday. I don't consider develop completely stable, but I don't believe there is any PR currently merged to it that would cause instability so you can try working off from that branch.

@altendky
Copy link
Contributor Author

Ah, I forget to look around for separate release/dev branches... :| Thanks. I'll give that a try once I get all my existing tests passing for BladeBit in plotman and actually start running it.

@altendky
Copy link
Contributor Author

It did work, thanks again to both of you. I did get a preliminary version of BladeBit support in plotman last night in ericaltendorf/plotman#916. Other than the automated tests, I am only aware of it having been run briefly on my insufficient laptop where it was able to launch and detect a BladeBit process.

@harold-b
Copy link
Contributor

Thank you, Kyle! I appreciate you making this available for your vast community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants