Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some ElementFeature convenience functions #71

Open
2 tasks
rkurchin opened this issue Jun 4, 2021 · 5 comments
Open
2 tasks

some ElementFeature convenience functions #71

rkurchin opened this issue Jun 4, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest!

Comments

@rkurchin
Copy link
Member

rkurchin commented Jun 4, 2021

  • pull all possible values (categorical) or range (continuous) of encodable values
  • dispatch encoding to elemental symbols (could be nice for demos)
@rkurchin rkurchin added enhancement New feature or request good first issue Good for newcomers labels Jun 4, 2021
@thazhemadam
Copy link
Member

pull all possible values (categorical) or range (continuous) of encodable values

Without actually creating an ElementFeatureDescriptor object?

@rkurchin
Copy link
Member Author

rkurchin commented Jun 4, 2021

no, as a function with the EFD as an input (one thing I eventually want to play with is direct numerical encoding (as opposed to one-hot bins) and for that we'll need to be able to do things like normalize values for model input)

@thazhemadam
Copy link
Member

If having different encoding schemes for an ElementFeatureDescriptor object is an idea, should we also consider bringing back encode_f and decode_f fields?

@rkurchin
Copy link
Member Author

rkurchin commented Jun 4, 2021

Yeah, I guess we might need to do that, since otherwise a lot of the fields (nbins, logspaced, etc.) would become irrelevant...so maybe the encoding functions would just get automatically built via arguments to the constructor that specify the encoding?

@rkurchin
Copy link
Member Author

rkurchin commented Jun 4, 2021

there is appeal to always having them attached in terms of dispatching the encoding on just the abstract FD type rather than having to define it for each subtype

@thazhemadam thazhemadam added the hacktoberfest Hacktoberfest! label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest!
Projects
None yet
Development

No branches or pull requests

2 participants