Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using strings to create Featurizations via GraphNodeFeaturization doesn't work with things other than ElementFeatureDescriptors #129

Open
Boxylmer opened this issue Dec 2, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Boxylmer
Copy link

Boxylmer commented Dec 2, 2021

MWE Below:

using ChemistryFeaturization

# these work
featurization = GraphNodeFeaturization([
    "Group",
    "Row",
    "Block",
    "Atomic mass",
    "Atomic radius",
    "X",
])

# but with "isaromatic", which is a SpeciesFeatureDescriptor, it will not. (Block thrown in just for fun)
featurization = GraphNodeFeaturization([
    "Block",
    "isaromatic"
])

The error is: ERROR: LoadError: AssertionError: Feature isaromatic isn't in the lookup table!, so do these terms just need to simply be added?

@rkurchin
Copy link
Member

rkurchin commented Dec 7, 2021

Thanks for pointing this out, this definitely needs to be fixed! Will be sure to address in next version tag.

(The issue is that right now that convenience constructor for GraphNodeFeaturization assumes that everything is an ElementFeatureDescriptor because when I implemented it, SpeciesFeatureDescriptor didn't exist yet 😉)

@rkurchin rkurchin added the bug Something isn't working label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants