-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added ignore pattern matching for filesystem plugin #97
Conversation
this closes #93 btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can support both, with an option like |
@SHA65536 Thanks for contributing. |
Signed-off-by: SHA65536 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10x lgtm |
I added the
--ignore
flag to let the user add patterns for files to be ignored. A user may supply multiple patterns using this form:2ms filesystem --path path --ignore "*foo" --ignore "bar*"
I did not add tests as I am unsure how you guys want to test the plugins, worth discussing how a plugin test should be written.
Awaiting your feedback, cheers.
Close #93