Fix Bugs #46
Closed
Fix Bugs #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jossef
requested changes
Apr 16, 2023
plugins/confluence.go
Outdated
Comment on lines
128
to
130
| for _, space := range p.Spaces { | ||
| url += fmt.Sprintf("spaceKey=%s&", space) | ||
| } |
There was a problem hiding this comment.
add this to getSpaces implementation instead of creating a duplicate function getSpecificSpaces()
jossef
pushed a commit
that referenced
this pull request
Apr 17, 2023
This PR if replacing #46. @baruchiro made a PR with a better mechanism to search for only specified spaces. Now on this PR I'm just fixing a small issue with that implementation that is to replace the --confluence-spaces argument from string to stringArray. This will fix a issue we got when no spaces selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement mechanism to seach specific spaces. Fix bug
To do that user must specify the spaceKey. We are searching for spaceKey because Confluence Documentation API doesn't have a query parameter to seach by spaceName.
We can implement that I just didn't do that because I'm not sure if it makes sense. But we can get all spaces and use only the ones with the name selected.
This PR also fix this BUG
It's related to an authentication issue previously identifed by me and solved in other pending PRs.