Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPoker import errors #33

Open
Mudr0x opened this issue Apr 28, 2023 · 5 comments
Open

iPoker import errors #33

Mudr0x opened this issue Apr 28, 2023 · 5 comments

Comments

@Mudr0x
Copy link

Mudr0x commented Apr 28, 2023

Hello,

I'm facing since 1 or 2 months FpdbParseError for iPokerToFpdb.readPlayerStacks and Hand.addHoleCards for 10 to 20% of imported hands.
I doubt it is due to recent update on HH format but when I analyze and debug files all seems ok to me and I can't find where those issues come from.

Here's attached some HH examples.
Do some of you face same errors and can help me resolving those? Thanks in advance.

iPoker-HHs.zip

@jejellyroll-fr
Copy link

hello Mudr0x,
I started debugging, regarding iPokerToFpdb.readPlayerStacks the NUM regex substitution doesn't match with chips="1 480" ...didn't have time to debug everything ...but you can have a look at my unit test https://github.com/jejellyroll-fr/fpdb-3/blob/main/pyfpdb/test_ipokertofpdb.py

@jejellyroll-fr
Copy link

Regarding iPokerToFpdb.readPlayerStacks, the bug is fixed, you can see my commit: jejellyroll-fr/fpdb-3@7c231a1. For Hand.addHoleCards i will investigate

@jejellyroll-fr
Copy link

all hands imported correctly now: jejellyroll-fr/fpdb-3@b85cfb8 but i don't have the problem with Hand.addHoleCards on your hands sample

@jejellyroll-fr
Copy link

@Mudr0x tx for sharing your hands ...now you have all the infos you need to modify version 2.7 of Chaz and make a pull request or @ChazDazzle can do it directly ;)

@Mudr0x
Copy link
Author

Mudr0x commented Jun 23, 2023

You're welcome, thx for your help. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants