Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command tab completion no longer works when a command does not start with / #4842

Closed
Felanbird opened this issue Sep 28, 2023 · 4 comments · Fixed by #4846
Closed

Command tab completion no longer works when a command does not start with / #4842

Felanbird opened this issue Sep 28, 2023 · 4 comments · Fixed by #4846
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user regression Issues that reverted existing functionality

Comments

@Felanbird
Copy link
Collaborator

Steps to replicate:

  1. Make a command
  2. Set the trigger to anything that doesn't start with / ( e.g command )
  3. Attempt to use tab-completion to complete the command
  4. guh
  5. Notice that once failing to tab complete the command, tab completion with a / works, despite the command not having a /

almost certainly caused by #4639

originally reported in discord: https://discord.com/channels/253897423439659008/459650160658481152/1156813105528061992

@Felanbird Felanbird added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user regression Issues that reverted existing functionality labels Sep 28, 2023
@Felanbird
Copy link
Collaborator Author

Unlucky but we definitely can't do that, since we have both #3583 and #4233 - both of which use commands as their workaround.

@Mm2PL
Copy link
Collaborator

Mm2PL commented Sep 28, 2023

Yeah, tab completion needs to go back to querying everything or most things for this to work.

@dnsge
Copy link
Contributor

dnsge commented Sep 29, 2023

If I'm understanding the original behavior, it should be trivial to fix:

this->emoteSource_.update(query);
this->usersSource_.update(query);

can be updated to also use the command source.

I'll do some tinkering to see if this restores the original behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user regression Issues that reverted existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants