Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back up window layout #2235

Closed
iAm-Ant opened this issue Nov 28, 2020 · 12 comments · Fixed by #5647
Closed

Back up window layout #2235

iAm-Ant opened this issue Nov 28, 2020 · 12 comments · Fixed by #5647

Comments

@iAm-Ant
Copy link

iAm-Ant commented Nov 28, 2020

Describe the bug
At times when updating/restarting your computer, your Chatterino settings and commands are reset.

To reproduce
There are already backup settings in the %appdata% folder, but there are no backup commands, and I would like to see that for the people who have a lot of commands saved like me.

Chatterino version
Chatterino 2.2.2 (commit 07fc0c3)

Operating system
Windows 10 Pro

Proposed solution
Back up commands.json and window-layout.json like settings

@iAm-Ant iAm-Ant added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user needs triage labels Nov 28, 2020
@leon-richardt
Copy link
Collaborator

👍 for backing up commands

@ALazyMeme
Copy link
Collaborator

ALazyMeme commented Nov 29, 2020

I think this is more a feature request than a bug 🤔

@leon-richardt
Copy link
Collaborator

While we're at it, should we also backup the window-layout.json file?

@zneix
Copy link
Collaborator

zneix commented Aug 15, 2021

Backing up everything from every instance of the settings manager would make sense imo - Windows users often report to me that their whole Chatterino data gets reset - that includes settings, layout, commands, perhaps irc if they were using it.
No idea what are the capabilities of the pajlada/settings library, but a backup folder where all backups would be stored would be idea imho.

@ALazyMeme
Copy link
Collaborator

ALazyMeme commented Aug 15, 2021

Fixed in #3168?

@zneix
Copy link
Collaborator

zneix commented Aug 19, 2021

Fixed in #3168?

Not really, we didn't track down what makes commnads /s settings "reset" on Windows machines. However adding backups for these is a very good step towards fighting this issue. I think it should stay up before we actually figure out a proper solution to how to stop this from happening though.

@ALazyMeme
Copy link
Collaborator

Describe the bug
At times when updating/restarting your computer, your Chatterino settings and commands are reset.

To reproduce
There are already backup settings in the %appdata% folder, but there are no backup commands, and I would like to see that for the people who have a lot of commands saved like me.

Chatterino version
Chatterino 2.2.2 (commit 07fc0c3)

Operating system
Windows 10 Pro

Do you by any chance have a username with characters from another language? Perhaps Chinese or polish or German characters? Anything "non standard" in the English language?

@Mm2PL Mm2PL mentioned this issue Aug 26, 2022
4 tasks
@Mm2PL Mm2PL changed the title Chatterino commands are reset when updating Windows. Back up window layout and commands Aug 26, 2022
@Mm2PL Mm2PL added enhancement and removed bug Something isn't working as intended, or works in a confusing/unintuitive way for the user OS: Windows labels Aug 26, 2022
@GreenComfyTea
Copy link

GreenComfyTea commented Dec 26, 2022

Happened to me twice in the same week. Window layout got yeeted. Settings and commands had backups but not window layout.

Settings Folder

I shut down the PC every evening and turn it back on in the morning. Both times I saw the layout gone after turning it back on. There were no crashes of windows nor chatterino. Chatterino is autostarted thru the shortcut in the Startup folder.

Pretty sure I didnt make any changes to chatterino or windows settings in the last month. And i havent had this issue before.

First time i had a lot of tabs open (~20). One of the tabs contained a lot of splits (~50).
Second time it was only 4 tabs, no splits.

Tech info Chatterino Nightly v2.3.5 (Not sure which commit, installed some time ago)

Host Name: GREENTEA-PC
OS Name: Microsoft Windows 10 Enterprise
OS Version: 10.0.19045 N/A Build 19045
OS Manufacturer: Microsoft Corporation
OS Configuration: Standalone Workstation
OS Build Type: Multiprocessor Free
Registered Owner: GreenTea
Registered Organization:
Original Install Date: 07/11/2022, 22:26:54
System Boot Time: 26/12/2022, 08:35:23
System Manufacturer: System manufacturer
System Model: System Product Name
System Type: x64-based PC
Processor(s): 1 Processor(s) Installed.
[01]: Intel64 Family 6 Model 158 Stepping 12 GenuineIntel ~3600 Mhz
BIOS Version: American Megatrends Inc. 2804, 15/04/2020
Windows Directory: C:\Windows
System Directory: C:\Windows\system32
Boot Device: \Device\HarddiskVolume4
System Locale: en-us;English (United States)
Input Locale: en-us;English (United States)
Time Zone: (UTC+02:00) Helsinki, Kyiv, Riga, Sofia, Tallinn, Vilnius
Total Physical Memory: 32 688 MB
Available Physical Memory: 25 959 MB
Virtual Memory: Max Size: 50 768 MB
Virtual Memory: Available: 38 913 MB
Virtual Memory: In Use: 11 855 MB
Page File Location(s): C:\pagefile.sys
D:\pagefile.sys
E:\pagefile.sys
Domain: WORKGROUP
Logon Server: \GREENTEA-PC
Hotfix(s): 8 Hotfix(s) Installed.
[01]: KB5020872
[02]: KB5000736
[03]: KB5012170
[04]: KB5015684
[05]: KB5021233
[06]: KB5018506
[07]: KB5020372
[08]: KB5001405
Network Card(s): 2 NIC(s) Installed.
[01]: Intel(R) Ethernet Connection (7) I219-V
Connection Name: Ethernet
Status: Media disconnected
[02]: TP-Link Gigabit PCI Express Adapter
Connection Name: Ethernet 3
DHCP Enabled: Yes
DHCP Server: 192.168.0.1
IP address(es)
[01]: 192.168.0.190

Hyper-V Requirements: VM Monitor Mode Extensions: Yes
Virtualization Enabled In Firmware: No
Second Level Address Translation: Yes
Data Execution Prevention Available: Yes

Off topic Suggestion *.json.bkp-X is not very handy format. I have to go thru each number individually to assign a program to open it (notepad++ in my case). Perhaps *.bkp-X.json would make more sense?

@pajlada
Copy link
Member

pajlada commented Dec 26, 2022

Not really relevant to the issue but to ensure everything saves properly, you can turn off Chatterino before turning off your computer @GreenComfyTea

@GreenComfyTea
Copy link

My issue sounds exactly like the original issue on the top and since the other one was merged into this one, I decided to report it here.
Your advice makes sense, thank you!

@pajlada pajlada changed the title Back up window layout and commands Back up window layout Dec 26, 2022
@pajlada
Copy link
Member

pajlada commented Dec 26, 2022

For the Off topic suggestion: Makes sense, there's some more things we can do with the settings/commands saving like auto-recovery if the original file is broken, saving the files with a proper file extension would make it easier for people to inspect them

@radobot
Copy link

radobot commented Jul 21, 2024

I've just had a situation where my disk got full a it resulted in chatterino losing all its settings (it created 0 byte files instead). Fortunately, I was able to just roll all of them back to one of the backups, well, all except window-layout.json. So now I'm stuck trying to remember what I had previously opened and what filters applied.

So I would like to request for window-layout.json to get the same backup treatment like commands.json and settings.json already have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants