Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The mixed charts example without JavaScript shows up as three separate charts #4

Open
bkil opened this issue Mar 20, 2021 · 8 comments

Comments

@bkil
Copy link

bkil commented Mar 20, 2021

@ramiy
Copy link
Contributor

ramiy commented Mar 24, 2021

@bkil What is the problem with that? You can use three separate css charts to displayed as a single "Stock Chart"

@bkil
Copy link
Author

bkil commented Mar 24, 2021

I would expect these three charts to overlay, but with NoScript, they are displays one below the other. This would be a huge selling point for a NoScript/CSS-only library and should work, but I think some of the dynamic styles on the demo page interfere with these divs. I didn't debug what causes it, though.

@ramiy
Copy link
Contributor

ramiy commented Mar 24, 2021

The example displays 3 charts atop one another using CSS (No JS). The demo has no dynamic styles.

Mixed-Charts-css

Same result on Chrome, Firefox and Edge. Do you see something different?

@bkil
Copy link
Author

bkil commented Mar 24, 2021

What extension did you use to disable JavaScript in your browser? This is how it looks like with ScriptSafe or uMatrix:
chartcss

@ramiy
Copy link
Contributor

ramiy commented Mar 24, 2021

I don't use browser extensions. Just open the page in Incognito or disable your browser extensions.

@bkil
Copy link
Author

bkil commented Mar 24, 2021

Again, this issue is about the example not showing with JavaScript disabled.

I always test CSS-only frameworks without JavaScript and if a demo does not look right without JavaScript, it is not convincing.

@ramiy
Copy link
Contributor

ramiy commented Mar 24, 2021

Again, this issue is about the example not showing with JavaScript disabled.

Ok, now I understand. Thank you for your patient clarifying the issue.

I did not tested with JavaScript disabled but I should note that the framework doesn't load any JS files, only CSS files.

I'll disable JS and share the conclusions here.

@ramiy
Copy link
Contributor

ramiy commented Mar 25, 2021

@bkil tested...

I disabled JS on chrome and mixed charts stopped working. Very interesting result. CSS is not working as expected when JS is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants