Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passthrough device #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Passthrough device #174

wants to merge 1 commit into from

Conversation

francois141
Copy link
Collaborator

No description provided.

@francois141 francois141 added the enhancement New feature or request label Aug 31, 2024
@francois141 francois141 self-assigned this Aug 31, 2024
@francois141 francois141 changed the title Test device passthrough v2 Passthrough device Aug 31, 2024
@francois141
Copy link
Collaborator Author

francois141 commented Aug 31, 2024 •
edited
Loading

@CharlyCst Feel free to review after merging the test driver pr. Also I would suggest as a next step (or second commit in this pr) to refactor and deduplicate code from the crate platform. Currently we have a lot of code duplication and I don't think it is useful overall.

@francois141 francois141 force-pushed the test-device-passthrough-v2 branch 3 times, most recently from d3cddb1 to 90854f1 Compare August 31, 2024 08:54
@francois141 francois141 linked an issue Aug 31, 2024 that may be closed by this pull request
Add passthrough device #175
Open
@francois141 francois141 force-pushed the test-device-passthrough-v2 branch 9 times, most recently from 0141afa to f4eab53 Compare August 31, 2024 14:18
@CharlyCst
Copy link
Owner

I'll take look when I get some time :)
I'm away this week, so I'll be less reactive.

And yes I agree we do have a bunch of code duplicated, so it is indeed a good time to think about refactoring :)

@francois141
Implement pass through device
8adc7ee 
The number of PMP (Physical Memory Protection) registers is limited on any RISC-V platform. Currently, each memory-mapped virtual device requires a separate PMP entry. This commit introduces a solution that allows grouping all virtual devices under a single PMP entry by implementing a pass-through module in front of them.
@francois141
Copy link
Collaborator Author

I rebased the commit. Feel free to review

@CharlyCst
Copy link
Owner

Thanks! I will take a look after OSFC

@francois141
Copy link
Collaborator Author

@CharlyCst Do you want to review it soon? We should merge it once :-)

@CharlyCst
Copy link
Owner

I need to spend time thinking about it, I don't have the bandwidth right now so except if it's blocking I'll delay it a bit more. My feeling is that this kind of feature might need a bit of iteration before getting it right.
Sorry for the long delay on that one, it's on my todo-list once I get done with higher-priority items.

@francois141
Copy link
Collaborator Author

No emergency on that front :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlyCst CharlyCst Awaiting requested review from CharlyCst

Assignees

@francois141 francois141

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add passthrough device
2 participants
@francois141 @CharlyCst