Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue titles invisible and repo name background white #66

Open
ripdog opened this issue Feb 28, 2021 · 3 comments
Open

Issue titles invisible and repo name background white #66

ripdog opened this issue Feb 28, 2021 · 3 comments

Comments

@ripdog
Copy link

ripdog commented Feb 28, 2021

Hi there, thanks for the stylesheet.

Looks like github has pushed an update.
Screen Shot 2021-03-02 at 02 24 15-fullpage

As you can see Issue titles are the same colour as their backgrounds, and the background behind the repository name is white.

Also the page below the github footer is white.

@ripdog
Copy link
Author

ripdog commented Feb 28, 2021

Just noticed that the comment buttons below the issue comment box (the one I'm typing in now) and the notice about attaching files are miscoloured. Also the title of the issue ('ripdog commented 1 minute ago') is miscoloured.

@Nakonana
Copy link

If I may add to this: the grey text below the issues and in the pop-up that appears when hovering over the issue title are hard to read. The issue-link on hover appears dark blue on dark ground which is also a bit tricky.

As for fixes, issue titles become visible by changing text color for .Link--primary, .link-gray-dark and .Link--primary:hover, .link-gray-dark:hover , but I'm not sure (yet) if it will affect links in other places. ( :not(.IssueLabel) a:not(.IssueLabel) might be another option to play around with). The background for the repository name can be changed with .color-bg-secondary (but again, not sure, it'll affect other things). I didn't look into the pop-ups any further, so can't help with this one.

grafik

@tanujp99
Copy link

tanujp99 commented Apr 30, 2021

This is because GitHub has added the light-and-dark theme setting, and changing this setting to darker theme resolved both the issues.

edit: grammar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants