Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some page backgrounds are white again. #65

Open
jim-barber-he opened this issue Jan 20, 2021 · 6 comments
Open

Some page backgrounds are white again. #65

jim-barber-he opened this issue Jan 20, 2021 · 6 comments

Comments

@jim-barber-he
Copy link

Once again thank you for this awesome theme! :)

This problem only started happening for me today, so GitHub has changed something I guess.
A number of pages in GitHub are starting to have white backgrounds shine through.

Example
image

Even this issues page has a big block of white at the bottom, and you can see white around where I enter the title for this issue.
image

@jim-barber-he
Copy link
Author

The first example image didn't post, so trying again:
image

@GreatestFool
Copy link

Experiencing the same thing, seems like pages don't stretch properly.

E.g. this file has this problem but this one does not.

As a temporary fix, at least to make it look not-eye-bleeding-inducing at least, I activated dark mode under Appearance settings on my account. Works well enough :)

@tanujp99
Copy link

This is because GitHub has added the light-and-dark theme setting, and changing this setting to darker theme resolved the issues.

@GreatestFool
Copy link

Yes, that should be rather obvious in and of itself.

@jim-barber-he
Copy link
Author

GitHub's Dark theme isn't very nice though IMO.
The theme provided by this style is much nicer.

@GreatestFool
Copy link

Well, yes, that was why I said as a temporary fix. I'm rather sure few, including myself, want to have the clashing themes but it is still better than material and white-theme github clashing while we wait for an updated version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants