Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Integration with SmokeDetector and Metasmoke #7

Open
17 tasks
thesecretmaster opened this issue Jun 24, 2018 · 1 comment
Open
17 tasks

Integration with SmokeDetector and Metasmoke #7

thesecretmaster opened this issue Jun 24, 2018 · 1 comment

Comments

@thesecretmaster
Copy link
Member

thesecretmaster commented Jun 24, 2018

Here's a list of changes that need to be built into Metasmoke or SmokeDetector to make them compatible with Helios:

SmokeDetector:

  • Notifications
    • Keeps cache of notifications from Helios, reloads cache when it becomes active
    • Pushes new notifications to its cache and to Helios and sends a message to Metasmoke over the websocket (format TBD)
    • New command to kick cache
  • Black/Watch listing
    • Pushes black/watch list requests to Metasmoke over websocket (Format TBD)
      • Falls back to pushing black/watch list requests from privileged users to Helios
      • Shows error when Metasmoke is down and an unprivileged user attempts to edit the black/watch list
    • Keeps cache of black/watch list items from Helios, reloads cache when it becomes active
    • Post a message when a black/watch list item is approved (will receive a WS message from Metasmoke, format TBD)
    • New command to kick cache

Metasmoke:

  • Notifications
    • UI for viewing/editing
    • Cache which can be refreshed from Helios on button click
    • Can push items to cache when receiving a message on it's websocket to Smokey
  • Black/Watch listing
    • Recieve black/watch list requests from SmokeDetector (push to Helios if privileged, otherwise add to pending list)
    • UI for approving black/watch list requests
      • On approval push to Helios and send WS message to smokey
    • Cache can be refreshed with a button click
    • Send invalidation (or probably "please check this key again") notice to Helios at appropriate time when a SmokeDetector key is revoked / removed.

SmokeDetector/Metasmoke new websocket messages (format TBD):

  • MS -> SD Black/watch list item has been approved (reply "message posted")
  • SD -> MS New black/watch list item (reply "success")
  • SD -> MS New notification (reply "success")
  • MS -> SD Kick watch/black list / notification cache (reply "success")

Some questions:

Could Helios have some endpoint which gives changes since ?
On the MS/SD websockets, is there usually a "success" reply?

@Undo1
Copy link
Member

Undo1 commented Jul 8, 2018

Looks good to me, @AWegnerGitHub and maybe @quartata would know more about blacklisting details.

Edited to add sending a notice to Helios when a token gets invalidated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants