Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1559 Fix Issue #4258 #4277

Merged
merged 5 commits into from
Sep 9, 2021
Merged

EIP-1559 Fix Issue #4258 #4277

merged 5 commits into from
Sep 9, 2021

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Aug 27, 2021

  • Checks tx.type before deicing what gas params to add to tx

Closes #4258

@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Aug 27, 2021
@render
Copy link

render bot commented Aug 27, 2021

@coveralls
Copy link

coveralls commented Aug 27, 2021

Pull Request Test Coverage Report for Build 1210376041

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 425 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.5%) to 72.929%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-method/lib/index.js 3 94.03%
packages/web3-core-helpers/src/formatters.js 24 80.65%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 85 13.04%
packages/web3-eth-accounts/src/index.js 164 25.31%
Totals Coverage Status
Change from base Build 1195730440: -2.5%
Covered Lines: 3325
Relevant Lines: 4310

💛 - Coveralls

@spacesailor24 spacesailor24 marked this pull request as ready for review August 31, 2021 01:59
@sambacha
Copy link

Just a note further down in the codebase here:

https://github.com/ChainSafe/web3.js/blob/154908bfb6fd335b409d88a1e00c1a5db931c423/packages/web3-core-method/src/index.js#L869

was updated recently, see ethers-io/ethers.js#1817 / commit: ethers-io/ethers.js@7175e2e

the value should read: 0x9502F900 (2500000000)

@spacesailor24
Copy link
Contributor Author

Just a note further down in the codebase here:

https://github.com/ChainSafe/web3.js/blob/154908bfb6fd335b409d88a1e00c1a5db931c423/packages/web3-core-method/src/index.js#L869

was updated recently, see ethers-io/ethers.js#1817 / commit: ethers-io/ethers.js@7175e2e

the value should read: 0x9502F900 (2500000000)

Thank you @sambacha for bringing this to our attention!

luu-alex
luu-alex previously approved these changes Aug 31, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
jdevcs
jdevcs previously approved these changes Sep 2, 2021
@spacesailor24 spacesailor24 merged commit c70722b into 1.x Sep 9, 2021
@spacesailor24 spacesailor24 deleted the wyatt/1.x/eip1559-fix-4258 branch September 9, 2021 20:37
@spacesailor24 spacesailor24 mentioned this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If network supports EIP-1559, then we cannot send a legacy transaction
6 participants