Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update user-agent check for go-eth2-client #6958

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: update user-agent check for go-eth2-client #6958

merged 2 commits into from
Jul 15, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jul 15, 2024 •
edited
Loading

Motivation

Follow up to #6953 to check proper default header of go-eth-client.

Description

Update user-agent check for go-eth2-client

attestantio/go-eth2-client/http/http.go#L36-L37

// defaultUserAgent is sent with requests if no other user agent has been supplied.
const defaultUserAgent = "go-eth2-client/0.21.7"

For some requests it sets the other header Go-http-client, which is set by Go by default.

wemeetagain
wemeetagain previously approved these changes Jul 15, 2024
View reviewed changes
@nflaig nflaig marked this pull request as ready for review July 15, 2024 22:52
@nflaig nflaig requested a review from a team as a code owner July 15, 2024 22:52
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.53%. Comparing base (f66aae4) to head (266d48d).

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6958      +/-   ##
============================================
- Coverage     62.53%   62.53%   -0.01%     
============================================
  Files           575      575              
  Lines         61068    61068              
  Branches       2136     2132       -4     
============================================
- Hits          38187    38186       -1     
- Misses        22842    22843       +1     
  Partials         39       39

@wemeetagain wemeetagain merged commit d6175da into unstable Jul 15, 2024
19 of 20 checks passed
@wemeetagain wemeetagain deleted the nflaig/vouch-proper-workaround branch July 15, 2024 23:16
wemeetagain pushed a commit that referenced this pull request Jul 15, 2024
@nflaig @wemeetagain
fix: update user-agent check for go-eth2-client (#6958)
c1877bf 
* fix: update user-agent check for go-eth2-client

* Remove confusing comment
@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 9d09bf2 Previous: f66aae4 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 590.63 us/op 497.23 us/op 1.19
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 43.939 us/op 40.794 us/op 1.08
BLS verify - blst-native 1.0701 ms/op 1.1311 ms/op 0.95
BLS verifyMultipleSignatures 3 - blst-native 2.2658 ms/op 2.4082 ms/op 0.94
BLS verifyMultipleSignatures 8 - blst-native 5.0489 ms/op 5.3256 ms/op 0.95
BLS verifyMultipleSignatures 32 - blst-native 18.453 ms/op 19.616 ms/op 0.94
BLS verifyMultipleSignatures 64 - blst-native 36.428 ms/op 38.642 ms/op 0.94
BLS verifyMultipleSignatures 128 - blst-native 72.051 ms/op 76.595 ms/op 0.94
BLS deserializing 10000 signatures 790.28 ms/op 786.56 ms/op 1.00
BLS deserializing 100000 signatures 7.9275 s/op 7.9807 s/op 0.99
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.1311 ms/op 1.2395 ms/op 0.91
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.2853 ms/op 1.3038 ms/op 0.99
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.0171 ms/op 2.0416 ms/op 0.99
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.3437 ms/op 3.0404 ms/op 1.10
BLS verifyMultipleSignatures - same message - 128 - blst-native 4.7562 ms/op 6.5843 ms/op 0.72
BLS aggregatePubkeys 32 - blst-native 22.013 us/op 22.953 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 83.692 us/op 89.363 us/op 0.94
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 50.935 ms/op 56.725 ms/op 0.90
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 54.182 ms/op 65.918 ms/op 0.82
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 34.271 ms/op 35.205 ms/op 0.97
getSlashingsAndExits - default max 77.467 us/op 84.135 us/op 0.92
getSlashingsAndExits - 2k 262.62 us/op 283.74 us/op 0.93
proposeBlockBody type=full, size=empty 5.0604 ms/op 4.9869 ms/op 1.01
isKnown best case - 1 super set check 458.00 ns/op 475.00 ns/op 0.96
isKnown normal case - 2 super set checks 471.00 ns/op 468.00 ns/op 1.01
isKnown worse case - 16 super set checks 468.00 ns/op 449.00 ns/op 1.04
InMemoryCheckpointStateCache - add get delete 4.7190 us/op 6.3800 us/op 0.74
validate api signedAggregateAndProof - struct 2.3057 ms/op 2.4167 ms/op 0.95
validate gossip signedAggregateAndProof - struct 2.3162 ms/op 2.4067 ms/op 0.96
validate gossip attestation - vc 640000 1.1141 ms/op 1.1332 ms/op 0.98
batch validate gossip attestation - vc 640000 - chunk 32 132.11 us/op 138.50 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 64 114.27 us/op 119.67 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 128 105.44 us/op 106.57 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 256 103.65 us/op 107.33 us/op 0.97
pickEth1Vote - no votes 826.45 us/op 851.49 us/op 0.97
pickEth1Vote - max votes 7.8192 ms/op 6.9035 ms/op 1.13
pickEth1Vote - Eth1Data hashTreeRoot value x2048 16.006 ms/op 12.214 ms/op 1.31
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 20.099 ms/op 14.249 ms/op 1.41
pickEth1Vote - Eth1Data fastSerialize value x2048 378.89 us/op 381.81 us/op 0.99
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.3291 ms/op 2.9817 ms/op 1.79
bytes32 toHexString 591.00 ns/op 585.00 ns/op 1.01
bytes32 Buffer.toString(hex) 438.00 ns/op 436.00 ns/op 1.00
bytes32 Buffer.toString(hex) from Uint8Array 531.00 ns/op 527.00 ns/op 1.01
bytes32 Buffer.toString(hex) + 0x 447.00 ns/op 436.00 ns/op 1.03
Object access 1 prop 0.33500 ns/op 0.31400 ns/op 1.07
Map access 1 prop 0.33400 ns/op 0.32700 ns/op 1.02
Object get x1000 5.0930 ns/op 5.3450 ns/op 0.95
Map get x1000 5.8750 ns/op 6.0030 ns/op 0.98
Object set x1000 22.360 ns/op 22.819 ns/op 0.98
Map set x1000 18.690 ns/op 18.902 ns/op 0.99
Return object 10000 times 0.30070 ns/op 0.30130 ns/op 1.00
Throw Error 10000 times 2.8953 us/op 2.7365 us/op 1.06
fastMsgIdFn sha256 / 200 bytes 1.9560 us/op 1.9680 us/op 0.99
fastMsgIdFn h32 xxhash / 200 bytes 420.00 ns/op 398.00 ns/op 1.06
fastMsgIdFn h64 xxhash / 200 bytes 471.00 ns/op 449.00 ns/op 1.05
fastMsgIdFn sha256 / 1000 bytes 5.9420 us/op 5.9100 us/op 1.01
fastMsgIdFn h32 xxhash / 1000 bytes 545.00 ns/op 517.00 ns/op 1.05
fastMsgIdFn h64 xxhash / 1000 bytes 546.00 ns/op 510.00 ns/op 1.07
fastMsgIdFn sha256 / 10000 bytes 50.810 us/op 49.855 us/op 1.02
fastMsgIdFn h32 xxhash / 10000 bytes 1.9110 us/op 1.8740 us/op 1.02
fastMsgIdFn h64 xxhash / 10000 bytes 1.3520 us/op 1.2970 us/op 1.04
send data - 1000 256B messages 9.9745 ms/op 10.022 ms/op 1.00
send data - 1000 512B messages 13.577 ms/op 13.460 ms/op 1.01
send data - 1000 1024B messages 22.513 ms/op 19.849 ms/op 1.13
send data - 1000 1200B messages 24.529 ms/op 25.031 ms/op 0.98
send data - 1000 2048B messages 29.783 ms/op 29.598 ms/op 1.01
send data - 1000 4096B messages 26.054 ms/op 26.118 ms/op 1.00
send data - 1000 16384B messages 63.743 ms/op 69.234 ms/op 0.92
send data - 1000 65536B messages 255.07 ms/op 260.54 ms/op 0.98
enrSubnets - fastDeserialize 64 bits 1.1300 us/op 1.1430 us/op 0.99
enrSubnets - ssz BitVector 64 bits 517.00 ns/op 567.00 ns/op 0.91
enrSubnets - fastDeserialize 4 bits 329.00 ns/op 346.00 ns/op 0.95
enrSubnets - ssz BitVector 4 bits 511.00 ns/op 570.00 ns/op 0.90
prioritizePeers score -10:0 att 32-0.1 sync 2-0 124.37 us/op 141.22 us/op 0.88
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 144.93 us/op 133.47 us/op 1.09
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 259.71 us/op 270.50 us/op 0.96
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 416.51 us/op 469.50 us/op 0.89
prioritizePeers score 0:0 att 64-1 sync 4-1 556.74 us/op 643.82 us/op 0.86
array of 16000 items push then shift 1.2135 us/op 1.2310 us/op 0.99
LinkedList of 16000 items push then shift 7.3710 ns/op 7.2420 ns/op 1.02
array of 16000 items push then pop 107.47 ns/op 87.431 ns/op 1.23
LinkedList of 16000 items push then pop 6.3600 ns/op 6.1180 ns/op 1.04
array of 24000 items push then shift 1.8488 us/op 1.7586 us/op 1.05
LinkedList of 24000 items push then shift 6.9420 ns/op 6.7120 ns/op 1.03
array of 24000 items push then pop 144.13 ns/op 112.97 ns/op 1.28
LinkedList of 24000 items push then pop 6.1780 ns/op 6.3400 ns/op 0.97
intersect bitArray bitLen 8 5.2530 ns/op 5.0940 ns/op 1.03
intersect array and set length 8 38.537 ns/op 38.506 ns/op 1.00
intersect bitArray bitLen 128 29.955 ns/op 25.361 ns/op 1.18
intersect array and set length 128 562.42 ns/op 559.49 ns/op 1.01
bitArray.getTrueBitIndexes() bitLen 128 2.1190 us/op 2.3330 us/op 0.91
bitArray.getTrueBitIndexes() bitLen 248 3.7440 us/op 3.4750 us/op 1.08
bitArray.getTrueBitIndexes() bitLen 512 8.6930 us/op 7.9970 us/op 1.09
Buffer.concat 32 items 976.00 ns/op 946.00 ns/op 1.03
Uint8Array.set 32 items 1.7070 us/op 1.6350 us/op 1.04
Buffer.copy 1.7360 us/op 1.6510 us/op 1.05
Uint8Array.set - with subarray 2.3960 us/op 2.1540 us/op 1.11
Uint8Array.set - without subarray 1.5360 us/op 1.6450 us/op 0.93
getUint32 - dataview 421.00 ns/op 436.00 ns/op 0.97
getUint32 - manual 324.00 ns/op 332.00 ns/op 0.98
Set add up to 64 items then delete first 1.6802 us/op 1.7915 us/op 0.94
OrderedSet add up to 64 items then delete first 2.6823 us/op 3.2250 us/op 0.83
Set add up to 64 items then delete last 1.9650 us/op 2.0748 us/op 0.95
OrderedSet add up to 64 items then delete last 3.1463 us/op 3.2724 us/op 0.96
Set add up to 64 items then delete middle 1.9835 us/op 2.0886 us/op 0.95
OrderedSet add up to 64 items then delete middle 4.3816 us/op 4.6972 us/op 0.93
Set add up to 128 items then delete first 3.8571 us/op 4.0926 us/op 0.94
OrderedSet add up to 128 items then delete first 5.7534 us/op 6.1692 us/op 0.93
Set add up to 128 items then delete last 3.8585 us/op 4.0776 us/op 0.95
OrderedSet add up to 128 items then delete last 6.0116 us/op 6.3791 us/op 0.94
Set add up to 128 items then delete middle 3.7417 us/op 4.0624 us/op 0.92
OrderedSet add up to 128 items then delete middle 11.389 us/op 11.430 us/op 1.00
Set add up to 256 items then delete first 7.5711 us/op 8.2109 us/op 0.92
OrderedSet add up to 256 items then delete first 11.536 us/op 12.107 us/op 0.95
Set add up to 256 items then delete last 7.7078 us/op 8.0101 us/op 0.96
OrderedSet add up to 256 items then delete last 12.124 us/op 12.555 us/op 0.97
Set add up to 256 items then delete middle 7.5751 us/op 8.0303 us/op 0.94
OrderedSet add up to 256 items then delete middle 33.057 us/op 34.808 us/op 0.95
transfer serialized Status (84 B) 1.4370 us/op 1.3690 us/op 1.05
copy serialized Status (84 B) 1.1600 us/op 1.1410 us/op 1.02
transfer serialized SignedVoluntaryExit (112 B) 1.4720 us/op 1.4570 us/op 1.01
copy serialized SignedVoluntaryExit (112 B) 1.2310 us/op 1.1680 us/op 1.05
transfer serialized ProposerSlashing (416 B) 1.8100 us/op 1.5990 us/op 1.13
copy serialized ProposerSlashing (416 B) 1.5850 us/op 1.3390 us/op 1.18
transfer serialized Attestation (485 B) 1.7770 us/op 1.6320 us/op 1.09
copy serialized Attestation (485 B) 1.5910 us/op 1.3050 us/op 1.22
transfer serialized AttesterSlashing (33232 B) 2.1760 us/op 1.7330 us/op 1.26
copy serialized AttesterSlashing (33232 B) 4.7950 us/op 3.6590 us/op 1.31
transfer serialized Small SignedBeaconBlock (128000 B) 2.9090 us/op 2.0850 us/op 1.40
copy serialized Small SignedBeaconBlock (128000 B) 13.635 us/op 9.2370 us/op 1.48
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1020 us/op 2.3030 us/op 1.35
copy serialized Avg SignedBeaconBlock (200000 B) 19.166 us/op 14.107 us/op 1.36
transfer serialized BlobsSidecar (524380 B) 2.8660 us/op 2.5930 us/op 1.11
copy serialized BlobsSidecar (524380 B) 192.97 us/op 77.923 us/op 2.48
transfer serialized Big SignedBeaconBlock (1000000 B) 3.0150 us/op 3.1190 us/op 0.97
copy serialized Big SignedBeaconBlock (1000000 B) 136.75 us/op 232.23 us/op 0.59
pass gossip attestations to forkchoice per slot 2.7639 ms/op 2.8280 ms/op 0.98
forkChoice updateHead vc 100000 bc 64 eq 0 387.90 us/op 502.76 us/op 0.77
forkChoice updateHead vc 600000 bc 64 eq 0 2.3865 ms/op 2.5936 ms/op 0.92
forkChoice updateHead vc 1000000 bc 64 eq 0 4.1632 ms/op 4.3202 ms/op 0.96
forkChoice updateHead vc 600000 bc 320 eq 0 2.4685 ms/op 2.5929 ms/op 0.95
forkChoice updateHead vc 600000 bc 1200 eq 0 2.4174 ms/op 2.4462 ms/op 0.99
forkChoice updateHead vc 600000 bc 7200 eq 0 2.9099 ms/op 3.0369 ms/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 1000 9.2455 ms/op 9.4143 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 10000 9.1023 ms/op 9.6048 ms/op 0.95
forkChoice updateHead vc 600000 bc 64 eq 300000 11.929 ms/op 11.932 ms/op 1.00
computeDeltas 500000 validators 300 proto nodes 2.8496 ms/op 3.0333 ms/op 0.94
computeDeltas 500000 validators 1200 proto nodes 2.9341 ms/op 3.0685 ms/op 0.96
computeDeltas 500000 validators 7200 proto nodes 2.9666 ms/op 2.9913 ms/op 0.99
computeDeltas 750000 validators 300 proto nodes 4.3566 ms/op 4.5731 ms/op 0.95
computeDeltas 750000 validators 1200 proto nodes 4.2660 ms/op 4.5406 ms/op 0.94
computeDeltas 750000 validators 7200 proto nodes 4.3414 ms/op 4.4872 ms/op 0.97
computeDeltas 1400000 validators 300 proto nodes 8.1553 ms/op 8.2861 ms/op 0.98
computeDeltas 1400000 validators 1200 proto nodes 8.2196 ms/op 8.3465 ms/op 0.98
computeDeltas 1400000 validators 7200 proto nodes 8.0298 ms/op 8.4543 ms/op 0.95
computeDeltas 2100000 validators 300 proto nodes 12.240 ms/op 12.619 ms/op 0.97
computeDeltas 2100000 validators 1200 proto nodes 12.549 ms/op 12.274 ms/op 1.02
computeDeltas 2100000 validators 7200 proto nodes 12.108 ms/op 12.079 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 1.3534 ms/op 1.4163 ms/op 0.96
altair processAttestation - 250000 vs - 7PWei worstcase 2.1038 ms/op 2.1074 ms/op 1.00
altair processAttestation - setStatus - 1/6 committees join 72.417 us/op 66.689 us/op 1.09
altair processAttestation - setStatus - 1/3 committees join 126.64 us/op 128.76 us/op 0.98
altair processAttestation - setStatus - 1/2 committees join 178.93 us/op 187.74 us/op 0.95
altair processAttestation - setStatus - 2/3 committees join 278.02 us/op 257.59 us/op 1.08
altair processAttestation - setStatus - 4/5 committees join 386.60 us/op 384.49 us/op 1.01
altair processAttestation - setStatus - 100% committees join 485.23 us/op 452.30 us/op 1.07
altair processBlock - 250000 vs - 7PWei normalcase 2.8389 ms/op 4.3260 ms/op 0.66
altair processBlock - 250000 vs - 7PWei normalcase hashState 22.343 ms/op 22.702 ms/op 0.98
altair processBlock - 250000 vs - 7PWei worstcase 40.261 ms/op 39.682 ms/op 1.01
altair processBlock - 250000 vs - 7PWei worstcase hashState 68.038 ms/op 80.029 ms/op 0.85
phase0 processBlock - 250000 vs - 7PWei normalcase 1.8115 ms/op 1.7406 ms/op 1.04
phase0 processBlock - 250000 vs - 7PWei worstcase 22.738 ms/op 23.132 ms/op 0.98
altair processEth1Data - 250000 vs - 7PWei normalcase 247.37 us/op 252.26 us/op 0.98
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 5.8900 us/op 7.1420 us/op 0.82
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 17.636 us/op 10.130 us/op 1.74
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 6.0830 us/op 10.648 us/op 0.57
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 4.5570 us/op 4.9260 us/op 0.93
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 70.855 us/op 71.055 us/op 1.00
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 774.74 us/op 756.45 us/op 1.02
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.0578 ms/op 1.0412 ms/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.0324 ms/op 1.0644 ms/op 0.97
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 1.9400 ms/op 1.9686 ms/op 0.99
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.1240 ms/op 1.1454 ms/op 0.98
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 2.8822 ms/op 2.8550 ms/op 1.01
Tree 40 250000 create 186.10 ms/op 189.77 ms/op 0.98
Tree 40 250000 get(125000) 114.93 ns/op 108.38 ns/op 1.06
Tree 40 250000 set(125000) 573.10 ns/op 555.43 ns/op 1.03
Tree 40 250000 toArray() 9.4862 ms/op 13.456 ms/op 0.70
Tree 40 250000 iterate all - toArray() + loop 10.525 ms/op 10.840 ms/op 0.97
Tree 40 250000 iterate all - get(i) 39.202 ms/op 41.121 ms/op 0.95
MutableVector 250000 create 8.4104 ms/op 9.6329 ms/op 0.87
MutableVector 250000 get(125000) 5.8530 ns/op 5.8290 ns/op 1.00
MutableVector 250000 set(125000) 179.90 ns/op 188.34 ns/op 0.96
MutableVector 250000 toArray() 2.7227 ms/op 2.5947 ms/op 1.05
MutableVector 250000 iterate all - toArray() + loop 2.7442 ms/op 2.7082 ms/op 1.01
MutableVector 250000 iterate all - get(i) 1.4231 ms/op 1.4313 ms/op 0.99
Array 250000 create 2.3944 ms/op 2.3296 ms/op 1.03
Array 250000 clone - spread 1.3512 ms/op 1.3397 ms/op 1.01
Array 250000 get(125000) 0.59000 ns/op 0.57600 ns/op 1.02
Array 250000 set(125000) 0.60000 ns/op 0.58700 ns/op 1.02
Array 250000 iterate all - loop 77.809 us/op 77.603 us/op 1.00
effectiveBalanceIncrements clone Uint8Array 300000 14.741 us/op 14.991 us/op 0.98
effectiveBalanceIncrements clone MutableVector 300000 324.00 ns/op 309.00 ns/op 1.05
effectiveBalanceIncrements rw all Uint8Array 300000 167.60 us/op 168.43 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 58.367 ms/op 60.307 ms/op 0.97
phase0 afterProcessEpoch - 250000 vs - 7PWei 73.776 ms/op 77.180 ms/op 0.96
phase0 beforeProcessEpoch - 250000 vs - 7PWei 35.521 ms/op 38.400 ms/op 0.93
altair processEpoch - mainnet_e81889 345.04 ms/op 357.71 ms/op 0.96
mainnet_e81889 - altair beforeProcessEpoch 34.579 ms/op 35.363 ms/op 0.98
mainnet_e81889 - altair processJustificationAndFinalization 10.463 us/op 9.1880 us/op 1.14
mainnet_e81889 - altair processInactivityUpdates 5.4930 ms/op 5.3462 ms/op 1.03
mainnet_e81889 - altair processRewardsAndPenalties 54.319 ms/op 47.263 ms/op 1.15
mainnet_e81889 - altair processRegistryUpdates 1.7790 us/op 1.4330 us/op 1.24
mainnet_e81889 - altair processSlashings 706.00 ns/op 548.00 ns/op 1.29
mainnet_e81889 - altair processEth1DataReset 652.00 ns/op 762.00 ns/op 0.86
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3752 ms/op 1.3203 ms/op 1.04
mainnet_e81889 - altair processSlashingsReset 2.3710 us/op 2.1770 us/op 1.09
mainnet_e81889 - altair processRandaoMixesReset 2.6490 us/op 2.6080 us/op 1.02
mainnet_e81889 - altair processHistoricalRootsUpdate 685.00 ns/op 657.00 ns/op 1.04
mainnet_e81889 - altair processParticipationFlagUpdates 1.3240 us/op 1.3620 us/op 0.97
mainnet_e81889 - altair processSyncCommitteeUpdates 565.00 ns/op 603.00 ns/op 0.94
mainnet_e81889 - altair afterProcessEpoch 79.907 ms/op 76.152 ms/op 1.05
capella processEpoch - mainnet_e217614 1.2281 s/op 1.2317 s/op 1.00
mainnet_e217614 - capella beforeProcessEpoch 226.15 ms/op 224.18 ms/op 1.01
mainnet_e217614 - capella processJustificationAndFinalization 11.046 us/op 8.8330 us/op 1.25
mainnet_e217614 - capella processInactivityUpdates 15.048 ms/op 15.034 ms/op 1.00
mainnet_e217614 - capella processRewardsAndPenalties 263.14 ms/op 268.64 ms/op 0.98
mainnet_e217614 - capella processRegistryUpdates 11.801 us/op 12.746 us/op 0.93
mainnet_e217614 - capella processSlashings 747.00 ns/op 838.00 ns/op 0.89
mainnet_e217614 - capella processEth1DataReset 693.00 ns/op 683.00 ns/op 1.01
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.5860 ms/op 3.9188 ms/op 1.17
mainnet_e217614 - capella processSlashingsReset 1.7850 us/op 2.2180 us/op 0.80
mainnet_e217614 - capella processRandaoMixesReset 1.8410 us/op 2.7550 us/op 0.67
mainnet_e217614 - capella processHistoricalRootsUpdate 741.00 ns/op 668.00 ns/op 1.11
mainnet_e217614 - capella processParticipationFlagUpdates 2.0730 us/op 1.2210 us/op 1.70
mainnet_e217614 - capella afterProcessEpoch 249.14 ms/op 242.44 ms/op 1.03
phase0 processEpoch - mainnet_e58758 345.38 ms/op 342.66 ms/op 1.01
mainnet_e58758 - phase0 beforeProcessEpoch 94.391 ms/op 92.074 ms/op 1.03
mainnet_e58758 - phase0 processJustificationAndFinalization 6.5250 us/op 10.637 us/op 0.61
mainnet_e58758 - phase0 processRewardsAndPenalties 35.520 ms/op 32.023 ms/op 1.11
mainnet_e58758 - phase0 processRegistryUpdates 3.9340 us/op 5.9880 us/op 0.66
mainnet_e58758 - phase0 processSlashings 789.00 ns/op 832.00 ns/op 0.95
mainnet_e58758 - phase0 processEth1DataReset 736.00 ns/op 703.00 ns/op 1.05
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1336 ms/op 1.1366 ms/op 1.00
mainnet_e58758 - phase0 processSlashingsReset 2.6170 us/op 2.5820 us/op 1.01
mainnet_e58758 - phase0 processRandaoMixesReset 2.6560 us/op 3.0420 us/op 0.87
mainnet_e58758 - phase0 processHistoricalRootsUpdate 701.00 ns/op 730.00 ns/op 0.96
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9030 us/op 2.6430 us/op 1.48
mainnet_e58758 - phase0 afterProcessEpoch 66.998 ms/op 63.791 ms/op 1.05
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2658 ms/op 750.90 us/op 1.69
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5801 ms/op 1.5164 ms/op 1.04
altair processInactivityUpdates - 250000 normalcase 19.023 ms/op 20.046 ms/op 0.95
altair processInactivityUpdates - 250000 worstcase 19.623 ms/op 19.546 ms/op 1.00
phase0 processRegistryUpdates - 250000 normalcase 3.3060 us/op 3.0340 us/op 1.09
phase0 processRegistryUpdates - 250000 badcase_full_deposits 290.84 us/op 304.46 us/op 0.96
phase0 processRegistryUpdates - 250000 worstcase 0.5 113.24 ms/op 109.85 ms/op 1.03
altair processRewardsAndPenalties - 250000 normalcase 47.285 ms/op 42.822 ms/op 1.10
altair processRewardsAndPenalties - 250000 worstcase 49.461 ms/op 43.023 ms/op 1.15
phase0 getAttestationDeltas - 250000 normalcase 5.5179 ms/op 5.7960 ms/op 0.95
phase0 getAttestationDeltas - 250000 worstcase 5.6446 ms/op 5.6585 ms/op 1.00
phase0 processSlashings - 250000 worstcase 86.370 us/op 79.215 us/op 1.09
altair processSyncCommitteeUpdates - 250000 100.25 ms/op 97.304 ms/op 1.03
BeaconState.hashTreeRoot - No change 474.00 ns/op 447.00 ns/op 1.06
BeaconState.hashTreeRoot - 1 full validator 125.16 us/op 103.08 us/op 1.21
BeaconState.hashTreeRoot - 32 full validator 1.4832 ms/op 1.1129 ms/op 1.33
BeaconState.hashTreeRoot - 512 full validator 11.293 ms/op 11.811 ms/op 0.96
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 137.75 us/op 136.24 us/op 1.01
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.8484 ms/op 1.8913 ms/op 0.98
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 25.170 ms/op 24.680 ms/op 1.02
BeaconState.hashTreeRoot - 1 balances 96.438 us/op 97.746 us/op 0.99
BeaconState.hashTreeRoot - 32 balances 914.36 us/op 853.79 us/op 1.07
BeaconState.hashTreeRoot - 512 balances 8.4339 ms/op 8.2460 ms/op 1.02
BeaconState.hashTreeRoot - 250000 balances 164.72 ms/op 185.25 ms/op 0.89
aggregationBits - 2048 els - zipIndexesInBitList 20.757 us/op 19.166 us/op 1.08
byteArrayEquals 32 46.052 ns/op 48.504 ns/op 0.95
Buffer.compare 32 14.670 ns/op 15.196 ns/op 0.97
byteArrayEquals 1024 1.2046 us/op 1.2236 us/op 0.98
Buffer.compare 1024 22.785 ns/op 23.431 ns/op 0.97
byteArrayEquals 16384 19.147 us/op 19.529 us/op 0.98
Buffer.compare 16384 182.74 ns/op 180.17 ns/op 1.01
byteArrayEquals 123687377 144.81 ms/op 152.53 ms/op 0.95
Buffer.compare 123687377 5.2867 ms/op 4.8519 ms/op 1.09
byteArrayEquals 32 - diff last byte 45.934 ns/op 47.904 ns/op 0.96
Buffer.compare 32 - diff last byte 15.020 ns/op 16.351 ns/op 0.92
byteArrayEquals 1024 - diff last byte 1.2098 us/op 1.2778 us/op 0.95
Buffer.compare 1024 - diff last byte 23.105 ns/op 23.573 ns/op 0.98
byteArrayEquals 16384 - diff last byte 19.239 us/op 20.227 us/op 0.95
Buffer.compare 16384 - diff last byte 166.18 ns/op 202.22 ns/op 0.82
byteArrayEquals 123687377 - diff last byte 145.94 ms/op 151.73 ms/op 0.96
Buffer.compare 123687377 - diff last byte 5.3069 ms/op 4.1268 ms/op 1.29
byteArrayEquals 32 - random bytes 4.7730 ns/op 4.9410 ns/op 0.97
Buffer.compare 32 - random bytes 15.132 ns/op 16.519 ns/op 0.92
byteArrayEquals 1024 - random bytes 4.8010 ns/op 4.9270 ns/op 0.97
Buffer.compare 1024 - random bytes 14.968 ns/op 16.797 ns/op 0.89
byteArrayEquals 16384 - random bytes 4.7470 ns/op 4.8780 ns/op 0.97
Buffer.compare 16384 - random bytes 14.947 ns/op 16.930 ns/op 0.88
byteArrayEquals 123687377 - random bytes 7.5700 ns/op 7.8200 ns/op 0.97
Buffer.compare 123687377 - random bytes 17.810 ns/op 19.650 ns/op 0.91
regular array get 100000 times 29.782 us/op 30.938 us/op 0.96
wrappedArray get 100000 times 29.795 us/op 30.803 us/op 0.97
arrayWithProxy get 100000 times 9.3731 ms/op 9.5704 ms/op 0.98
ssz.Root.equals 43.062 ns/op 42.571 ns/op 1.01
byteArrayEquals 41.894 ns/op 38.534 ns/op 1.09
Buffer.compare 8.7400 ns/op 8.6440 ns/op 1.01
shuffle list - 16384 els 5.6114 ms/op 5.6819 ms/op 0.99
shuffle list - 250000 els 82.330 ms/op 83.449 ms/op 0.99
processSlot - 1 slots 15.489 us/op 13.493 us/op 1.15
processSlot - 32 slots 2.6569 ms/op 2.3789 ms/op 1.12
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 42.180 ms/op 42.497 ms/op 0.99
getCommitteeAssignments - req 1 vs - 250000 vc 1.7775 ms/op 1.7939 ms/op 0.99
getCommitteeAssignments - req 100 vs - 250000 vc 3.4109 ms/op 3.5044 ms/op 0.97
getCommitteeAssignments - req 1000 vs - 250000 vc 3.7404 ms/op 3.7734 ms/op 0.99
findModifiedValidators - 10000 modified validators 238.09 ms/op 236.52 ms/op 1.01
findModifiedValidators - 1000 modified validators 152.15 ms/op 157.34 ms/op 0.97
findModifiedValidators - 100 modified validators 169.61 ms/op 145.85 ms/op 1.16
findModifiedValidators - 10 modified validators 161.82 ms/op 145.33 ms/op 1.11
findModifiedValidators - 1 modified validators 158.48 ms/op 146.73 ms/op 1.08
findModifiedValidators - no difference 152.42 ms/op 166.04 ms/op 0.92
compare ViewDUs 3.3251 s/op 2.9693 s/op 1.12
compare each validator Uint8Array 1.5528 s/op 982.07 ms/op 1.58
compare ViewDU to Uint8Array 639.45 ms/op 792.51 ms/op 0.81
migrate state 1000000 validators, 24 modified, 0 new 540.84 ms/op 582.21 ms/op 0.93
migrate state 1000000 validators, 1700 modified, 1000 new 709.29 ms/op 782.92 ms/op 0.91
migrate state 1000000 validators, 3400 modified, 2000 new 813.64 ms/op 958.61 ms/op 0.85
migrate state 1500000 validators, 24 modified, 0 new 501.35 ms/op 496.23 ms/op 1.01
migrate state 1500000 validators, 1700 modified, 1000 new 615.31 ms/op 743.47 ms/op 0.83
migrate state 1500000 validators, 3400 modified, 2000 new 964.54 ms/op 976.46 ms/op 0.99
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.9500 ns/op 5.9000 ns/op 1.01
state getBlockRootAtSlot - 250000 vs - 7PWei 532.71 ns/op 727.25 ns/op 0.73
computeProposers - vc 250000 6.3143 ms/op 5.9672 ms/op 1.06
computeEpochShuffling - vc 250000 81.873 ms/op 82.391 ms/op 0.99
getNextSyncCommittee - vc 250000 91.141 ms/op 97.857 ms/op 0.93
computeSigningRoot for AttestationData 15.170 us/op 19.048 us/op 0.80
hash AttestationData serialized data then Buffer.toString(base64) 1.1467 us/op 1.1531 us/op 0.99
toHexString serialized data 773.07 ns/op 770.00 ns/op 1.00
Buffer.toString(base64) 128.72 ns/op 131.20 ns/op 0.98

by benchmarkbot/action

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.20.1 🎉

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.21.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain