feat: decouple the deneb blob and block production #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
reviewed
May 15, 2023
twoeths
reviewed
May 15, 2023
| // Prune old blobSidecars for block production, those are only useful on their slot | ||
| if (this.config.getForkSeq(slot) >= ForkSeq.deneb) { | ||
| if (this.producedBlobSidecarsCache.size > 0) { | ||
| for (const [key, {slot: blobSlot}] of this.producedBlobSidecarsCache) { |
There was a problem hiding this comment.
not related to this PR, why don't we have producedBlobSidecarsCache with slot or block number as key so that we don't have to do a full scan here? I think we should have slot/block number in all of the consumer of the cache
There was a problem hiding this comment.
because its not re-org safe
There was a problem hiding this comment.
I mean we cache by slot, and then by block hash, and when we search we filter by slot first, then by block hash (I notice all of the consumers have slot).
it'd be easier to prune by slot
There was a problem hiding this comment.
hmmm can be done but sounds like an overkill since the freshest blobs are the most likely to be used in the proposal and are added to cache by increasing slot order, so pruning out by max naturally follows that order
twoeths
reviewed
May 15, 2023
twoeths
reviewed
May 15, 2023
twoeths
reviewed
May 15, 2023
twoeths
reviewed
May 15, 2023
add some breathing room reduce diff apply feedback use typeguards fix typo update comment
dapplion
suggested changes
May 18, 2023
packages/types/src/deneb/sszTypes.ts
Outdated
| signedBlobSidecars: SignedBlobSidecars, | ||
| }, | ||
| {typeName: "SignedBlockContents", jsonCase: "eth2"} | ||
| ); |
There was a problem hiding this comment.
Is this a spec'ed type? Types in packages/types should exclusively include spec'ed types, which need merkleization and / or serialization. Else define in beacon-node package
There was a problem hiding this comment.
i think its just beacon-apis serialization type, might be useful in eventually supporting ssz encoded/decoded responses in api, but for now will move into beacon-api package itself and import/use from there 👍
There was a problem hiding this comment.
@dapplion have done some refactoring on this, let me know if you find it suitable now
g11tech
changed the title
|
🎉 This PR is included in v1.9.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of by parts integration of free the blobs PR
Update the blob and block production and signing flow as per the decoupled blob spec
implements: