-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove noise pipes option #177
Conversation
@dapplion lint errors^^ |
So I had to disable prettier for this repo because it completely changed everything. But then there's this linter? So in Lodestar prettier is connected to the linter such that VSCode can understand what the linter wants and apply that automatically for you if you have |
|
@dapplion since this is breaking change, should we wait with releasing until we land changed connection encrypted interface? |
|
yea lets wait, should happen soon |
src/noise.ts
Outdated
@@ -220,7 +145,7 @@ export class Noise implements INoiseConnection { | |||
await handshake.exchange() | |||
await handshake.finish() | |||
|
|||
if (this.useNoisePipes && handshake.remotePeer) { | |||
if (handshake.remotePeer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this condition and keycache store should be removed
Still not working, I can DM to debug |
@achingbrain aegir dep-check is passing without warnings or errors for unused prod dependencies. Is that normal? |
As discussed offline, not need to keep code that will probably be never used
BREAKING CHANGE: noise pipes option no longer supported