Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pkg/finality-grandpa): Implement saturating_add and saturating_sub on VoteWeight #3511

Open
timwu20 opened this issue Oct 3, 2023 · 1 comment
Open

chore(pkg/finality-grandpa): Implement saturating_add and saturating_sub on VoteWeight #3511

timwu20 opened this issue Oct 3, 2023 · 1 comment
Labels
S-grandpa issues related to block finality.

Comments

@timwu20
Copy link
Contributor

timwu20 commented Oct 3, 2023

Issue summary

  • The rust code has some macros which generate the saturating_add and saturating_sub methods for certain types to avoid overflows.
  • We should implement this as well for VoteWeight in the go package

Other information and links
@EclesioMeloJunior EclesioMeloJunior self-assigned this Oct 4, 2023
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Oct 4, 2023
Merged
@EclesioMeloJunior
Copy link
Member

EclesioMeloJunior commented Oct 4, 2023 •
edited
Loading

@EclesioMeloJunior EclesioMeloJunior removed their assignment Nov 27, 2023
@P1sar P1sar added the S-grandpa issues related to block finality. label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-grandpa issues related to block finality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timwu20 @P1sar @EclesioMeloJunior