Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Filecoin.EthGetTransactionReceipt implementation #4759

Closed
4 tasks done
elmattic opened this issue Sep 11, 2024 · 6 comments · Fixed by #5093
Closed
4 tasks done

Complete Filecoin.EthGetTransactionReceipt implementation #4759

elmattic opened this issue Sep 11, 2024 · 6 comments · Fixed by #5093
Assignees

Comments

@elmattic
Copy link
Contributor

elmattic commented Sep 11, 2024

Issue summary

This is a follow-up issue for #4691.

The RPC method still needs to be fully implemented and thoroughly tested. What is missing is the support of logs in EthTxReceipt.

Task summary

  • [ ] Implement support for Events Implement chain events #4740
  • Re-introduce following methods for EthEventHandler *:
    • eth_get_events_for_filter
    • wait_for_height_processed
    • parse_eth_filter_spec
    • get_eth_logs_for_block_and_transaction
  • Re-introduce following functions **:
    • eth_bloom_set
    • eth_filter_logs_from_events
    • eth_log_from_event
    • eth_tx_hash_from_message_cid
    • eth_tx_hash_from_signed_message
  • [ ] Implement optional export of receipts in snapshots
  • Publicly expose GasOutputs in ref-fvm
  • Re-enable test by removing it from our filter lists

Acceptance Criteria

The API compare test is passing and EthGetTransactionReceipt is removed from our filter lists.

Other information and links

*: c228195
**: 52a06db

@LesnyRumcajs
Copy link
Member

Blocked by #4740

@elmattic
Copy link
Contributor Author

This issue is now unblocked, thanks to the spike.

@elmattic elmattic self-assigned this Sep 20, 2024
@LesnyRumcajs
Copy link
Member

Blocked by #4780

@elmattic
Copy link
Contributor Author

This issue is now unblocked.

@elmattic elmattic moved this from Ready to In progress in Forest Backlog 🌲 Nov 18, 2024
@elmattic
Copy link
Contributor Author

elmattic commented Dec 4, 2024

Let’s skip exporting receipts and focus on removing duplicate code between Forest and the ref-fvm.

The next release should expose it (see filecoin-project/ref-fvm#2091).

@LesnyRumcajs
Copy link
Member

Nice! New release should be done soonish (NV25 feature flag removal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants