Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite bindShapeMatrix #202

Closed
pjcozzi opened this issue Dec 30, 2016 · 2 comments
Closed

Do not overwrite bindShapeMatrix #202

pjcozzi opened this issue Dec 30, 2016 · 2 comments
Labels
bug good first issue An opportunity for first time contributors

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 30, 2016

with the identity matrix when adding defaults.

@lasalvavida can you please make this same fix in gltf-pipeline: CesiumGS/cesium#4792
@pjcozzi pjcozzi added good first issue An opportunity for first time contributors bug labels Dec 30, 2016
@javagl
Copy link
Contributor

javagl commented Dec 30, 2016 •
edited
Loading

Looking at https://github.com/AnalyticalGraphicsInc/gltf-pipeline/blob/13b5b65d32d625f3293cf6b1acab357c85eed42b/lib/addDefaults.js#L418 , it seems that this bug did not exist here, as it was fixed (based on some unit test) in 0fd4208
(A more systematic comparison of the addDefaults.js and the gltfDefaults.js could nevertheless be worthwhile...)

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Dec 31, 2016

Ah yes, shame on me for not also fixing Cesium then.

@pjcozzi pjcozzi closed this as completed Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjcozzi @javagl