-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables coloring of ModelExperimental #9881
Conversation
Thanks for the pull request @sanjeetsuhag!
Reviewers, don't forget to make sure that:
|
…mGS/cesium into model-experimental-color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjeetsuhag looks pretty solid overall, though it doesn't seem to work with instancing or the TriangleWithoutIndices
? is this supposed to happen?
…experimental-color
@ptrgags and I compared with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjeetsuhag really close, though now I think we need to double check the REPLACE color mode.
@sanjeetsuhag looks good, merging! |
Adds
color
,colorBlendAmount
andcolorBlendMode
toModelExperimental
.Sandcastle for setting
color
,colorBlendAmount
,colorBlendMode
onModelExperimental
Depends on #9873 being merged first.