Typed Arrays #858
Merged
Typed Arrays #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Source/Core/GeometryPipeline.js
Conflicts: Source/Core/Geometry.js Source/Core/GeometryPipeline.js Specs/Core/GeometryPipelineSpec.js
| positions = new Float64Array(6 * 4 * 3); | ||
|
|
||
| // +z face | ||
| positions[0] = min.x; positions[1] = min.y; positions[2] = max.z; |
There was a problem hiding this comment.
Generally we don't put more than one line on the same line, but this is OK here I suppose.
|
Sorry, actually viewer needs some fixes. |
Conflicts: Source/Core/Geometry.js
…normal test to increase test performance.
|
@pjcozzi I think this is ready for another review. I'm not sure what needed fixing in the viewer (before merging with the batching branch). |
|
Viewer is OK; I must of had a build issue. I cleaned up a few things. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify existing geometry and most of the geometry pipeline to use typed arrays.