-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extrude polygon #855
Closed
Closed
Extrude polygon #855
Changes from 12 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
64655e5
index on extrudePolygon: 86ce69c Added doc for removeDuplicates
dcc1dd7
On extrudePolygon: extrudepoly
5a9bff1
initial implementation
845b675
fix polygons with cut-outs
5fbe15e
Merge branch 'batching' into extrudePolygon
1a3e0d5
correct computation of attributes for walls
958a55d
documentation and tests
4b17635
updated cesiumviewer example
11591f4
Merge branch 'batching' into extrudePolygon
db4e09b
Merge branch 'batching' into extrudePolygon
1b61e26
Merge branch 'batching' into extrudePolygon
4b5ea62
Merge branch 'batching' into extrudePolygon
652e52b
check if undefined
5f2be15
fix indices, texture coordinates
594d101
reindex
d614336
Merge branch 'batching' into extrudePolygon
b98542c
wall subdivide
a40e3bb
Merge branch 'batching' into extrudePolygon
eb8e5e1
Merge branch 'batching' into extrudePolygon
db6bb59
fix bounding sphere
19be5f6
Merge branch 'batching' into extrudePolygon
c6eb932
correct wall normals
3a6eaa2
correct indices
ec95e14
Merge branch 'batching' into extrudePolygon
ef5e8d3
correct normals for polygon hierarchy
5ea4929
Merge branch 'batching' into extrudePolygon
7f5c87a
Merge branch 'batching' into extrudePolygon
4f55ff4
corrected subdivide wall positions
4871f60
correct wall tangent and binormal
4a4130c
relocate wrapLongitude
69672c4
correct tangent/binormal
9c6eef5
Merge branch 'batching' into extrudePolygon
d8a8550
missing GeometryAttributes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this.
PolygonGeometry
itself is new and already mentioned.