Model - nodesByName - use id if name is undefined #4870
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model.nodeTransformations
references nodes by their "name" property, which won't work if the node does not have a name. Since its a bit ambiguous what is the id vs. the name, this PR allows themodel._runtime.nodesByName
to be the id if the name is undefined.A different approach for the same problem is modifying
getNode
to look insidenodesByName
first and thennodes
. Same withgetMesh
andgetMateral
.This came up on the forum: https://groups.google.com/forum/#!topic/cesium-dev/Eqttp9vcR90