Specs refactor (final) #3803
Merged
Specs refactor (final) #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sun.destroy(); | ||
| }); | ||
|
|
||
| it('does not render without a render pass', function() { |
There was a problem hiding this comment.
I'm changing my mind here, but I think it's actually okay to include this test, but calling sun.update(scene.frameState) instead of scene.renderForSpecs()
|
While looking for occurences of The test fails if I change it to [0, 0, 0, 255]. Can you also look into that quickly? |
|
@lilleyse Updated with suggested changes |
| viewSun(scene.camera, scene.context.uniformState); | ||
| scene.frameState.passes.render = false; | ||
| scene.sun.update(scene); | ||
| expect(scene.context.readPixels()).toEqual(backgroundColor); |
There was a problem hiding this comment.
var command = scene.sun.update(scene.frameState);
expect(command).not.toBeDefined();
Is fine here.
|
Updated |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final cleanup for #1259
As of this revision, none of the scene specs contain references to
createContextorcreateFrameState.