Specs refactor pt.2 #3793
Merged
Specs refactor pt.2 #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return updateUntilDone(globe).then(function() { | ||
| expect(render(frameState, globe)).toBeGreaterThan(0); | ||
| expect(context.readPixels()).toEqual([255, 0, 0, 255]); |
There was a problem hiding this comment.
You should also check this line.
| }); | ||
|
|
||
| afterEach(function() { | ||
| globe.destroy(); | ||
| scene.imageryLayers.removeAll(); |
There was a problem hiding this comment.
Is there a reason for this change? Would globe.destroy() still work?
There was a problem hiding this comment.
If you look in Scene.js, the old globe is automatically destroyed when the new one is set
|
That's all my comments. Besides that it looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second iteration of the test refactoring in #1259