Refactored ViewportQuadSpec #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| us = context.uniformState; | ||
| us.update(context, createFrameState(createCamera())); | ||
| scene.primitives.add(viewportQuad); |
There was a problem hiding this comment.
I suggest writing
viewportQuad = new ViewportQuad();
scene.primitives.add(viewportQuad);
as
viewportQuad = scene.primitives.add(new ViewportQuad());
This code was written before add returned the added primitive.
Don't use Instead of adding the primitive in expect(scene.renderForSpecs()).toEqual([0, 0, 0, 255]);
scene.primitives.add(viewportQuad);
expect(scene.renderForSpecs()).not.toEqual([0, 0, 0, 255]);which, of course, makes my tip above not useful. |
|
Updated. |
| viewportQuad.rectangle = undefined; | ||
|
|
||
| expect(function() { | ||
| render(context, frameState, viewportQuad); | ||
| scene.primitives.add(viewportQuad); |
There was a problem hiding this comment.
Only put the part that we expect to throw in the callback so, here and below, move this above:
scene.primitives.add(viewportQuad);
|
Just that minor comment. |
|
Done |
|
Breathtaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1259
There's an issue where
ClearCommand.ALL.execute(context)doesn't seem to do anything, and instead the clear color ends up being the scene's background color (0,0,0,255). I noticed other specs account for this, like TextureAtlasSpec.I'm going to look into this more, but decided to start the pull request anyways.