-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplestyle #2162
Merged
Merged
Simplestyle #2162
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
53262e3
Merge branch 'maki' into simplestyle
mramato 44c8461
First cut at GeoJSON simplestyle implementation.
mramato d0806d5
Ongoing PinBuilder work.
mramato 1ff4487
Ongoing PinBuilder work.
mramato 66bd965
Add specs for new functionality.
mramato 3ed4a9d
Ongoing PinBuilder work
mramato 24e925d
Add specs for PinBuilder
mramato 44fc07e
Tweak examples, update CHANGES.
mramato ab3511b
Update CHANGES
mramato b14f459
Merge branch 'maki' into simplestyle
mramato 34048a6
Changes after review.
mramato 3b5fd06
Merge remote-tracking branch 'origin/master' into simplestyle
mramato e5cb3f4
Changes after review.
mramato 972d989
More cleanup after review.
mramato 2a44017
Fix bug in GeoJSON processing
mramato bd197ca
Improve GeoJSON feature name detection.
mramato 4ee2d2a
Use encodeURIComponent on maki icon id.
mramato 98b49c7
Changes after review.
mramato fb64b59
Fix typo, cleanup CHANGES
shunter f633859
`result` is required, not optional
shunter 9d2a314
Remove unused modules.
shunter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=Edge,chrome=1"> <!-- Use Chrome Frame in IE --> | ||
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no"> | ||
<meta name="description" content="Load GeoJSON with simplestyle information."> | ||
<meta name="cesium-sandcastle-labels" content="Showcases, DataSources"> | ||
<title>Cesium Demo</title> | ||
<script type="text/javascript" src="../Sandcastle-header.js"></script> | ||
<script type="text/javascript" src="../../../ThirdParty/requirejs-2.1.9/require.js"></script> | ||
<script type="text/javascript"> | ||
require.config({ | ||
baseUrl : '../../../Source', | ||
waitSeconds : 60 | ||
}); | ||
</script> | ||
</head> | ||
<body class="sandcastle-loading" data-sandcastle-bucket="bucket-requirejs.html"> | ||
<style> | ||
@import url(../templates/bucket.css); | ||
</style> | ||
<div id="cesiumContainer" class="fullSize"></div> | ||
<div id="loadingOverlay"><h1>Loading...</h1></div> | ||
<div id="toolbar"></div> | ||
<script id="cesium_sandcastle_script"> | ||
function startup(Cesium) { | ||
"use strict"; | ||
//Sandcastle_Begin | ||
//Create the viewer | ||
//Create the viewer | ||
var viewer = new Cesium.Viewer('cesiumContainer', {timeline : false, animation : false}); | ||
Cesium.viewerEntityMixin(viewer); | ||
|
||
//Load a GeoJSON file containing simplestyle information. | ||
//To learn more about simplestyle, see https://github.com/mapbox/simplestyle-spec | ||
viewer.dataSources.add(Cesium.GeoJsonDataSource.fromUrl('../../SampleData/simplestyles.geojson')); | ||
|
||
//Set the camera to view the data. | ||
var camera = viewer.scene.camera; | ||
camera.viewRectangle(Cesium.Rectangle.fromDegrees(-0.1, 0.2, 1.5, -1.1)); | ||
|
||
//In this particular example, the name of each entity is set to its maki icon identifier. | ||
//Clicking on each billboard will show it's identifier in the InfoBox. | ||
//Sandcastle_End | ||
Sandcastle.finishedLoading(); | ||
} | ||
if (typeof Cesium !== "undefined") { | ||
startup(Cesium); | ||
} else if (typeof require === "function") { | ||
require(["Cesium"], startup); | ||
} | ||
</script> | ||
</body> | ||
</html> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="utf-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=Edge,chrome=1"> <!-- Use Chrome Frame in IE --> | ||
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no"> | ||
<meta name="description" content="Load GeoJSON with simplestyle information."> | ||
<meta name="cesium-sandcastle-labels" content="Showcases, Tutorial"> | ||
<title>Cesium Demo</title> | ||
<script type="text/javascript" src="../Sandcastle-header.js"></script> | ||
<script type="text/javascript" src="../../../ThirdParty/requirejs-2.1.9/require.js"></script> | ||
<script type="text/javascript"> | ||
require.config({ | ||
baseUrl : '../../../Source', | ||
waitSeconds : 60 | ||
}); | ||
</script> | ||
</head> | ||
<body class="sandcastle-loading" data-sandcastle-bucket="bucket-requirejs.html"> | ||
<style> | ||
@import url(../templates/bucket.css); | ||
</style> | ||
<div id="cesiumContainer" class="fullSize"></div> | ||
<div id="loadingOverlay"><h1>Loading...</h1></div> | ||
<div id="toolbar"></div> | ||
<script id="cesium_sandcastle_script"> | ||
function startup(Cesium) { | ||
"use strict"; | ||
//Sandcastle_Begin | ||
var viewer = new Cesium.Viewer('cesiumContainer', {timeline : false, animation : false}); | ||
|
||
var pinBuilder = new Cesium.PinBuilder(); | ||
var billboardCollection = new Cesium.BillboardCollection(); | ||
viewer.scene.primitives.add(billboardCollection); | ||
|
||
//Create a blank, solid colored pin. | ||
Cesium.when(pinBuilder.fromColor(Cesium.Color.ROYALBLUE, 48), function(canvas){ | ||
billboardCollection.add({ | ||
image : canvas, | ||
verticalOrigin : Cesium.VerticalOrigin.BOTTOM, | ||
position : Cesium.Cartesian3.fromDegrees(-75.170726, 39.9208667, 0) | ||
}); | ||
}); | ||
|
||
//Create a black pin labeled with a quesiton mark. | ||
Cesium.when(pinBuilder.fromText('?', Cesium.Color.BLACK, 48), function(canvas){ | ||
billboardCollection.add({ | ||
image : canvas, | ||
verticalOrigin : Cesium.VerticalOrigin.BOTTOM, | ||
position : Cesium.Cartesian3.fromDegrees(-75.1698529, 39.9220071, 0) | ||
}); | ||
}); | ||
|
||
//Create a green pin labeled with a png file on the server. | ||
var url = Cesium.buildModuleUrl('Assets/Textures/maki/grocery.png'); | ||
Cesium.when(pinBuilder.fromUrl(url, Cesium.Color.GREEN, 48), function(canvas){ | ||
billboardCollection.add({ | ||
image : canvas, | ||
verticalOrigin : Cesium.VerticalOrigin.BOTTOM, | ||
position : Cesium.Cartesian3.fromDegrees(-75.1705217, 39.921786, 0) | ||
}); | ||
}); | ||
|
||
//Create a red pin representing a hospital from the maki icon set. | ||
Cesium.when(pinBuilder.fromMakiIconId('hospital', Cesium.Color.RED, 48), function(canvas) { | ||
billboardCollection.add({ | ||
image : canvas, | ||
verticalOrigin : Cesium.VerticalOrigin.BOTTOM, | ||
position : Cesium.Cartesian3.fromDegrees(-75.1698606, 39.9211275, 0) | ||
}); | ||
}); | ||
|
||
//Set the view to the location of our pins. | ||
var camera = viewer.scene.camera; | ||
camera.lookAt(Cesium.Cartesian3.fromDegrees(-75.1703817, 39.9182722, 250), | ||
Cesium.Cartesian3.fromDegrees(-75.1703817, 39.9212722, 0), Cesium.Cartesian3.UNIT_Z); | ||
//Sandcastle_End | ||
Sandcastle.finishedLoading(); | ||
} | ||
if (typeof Cesium !== "undefined") { | ||
startup(Cesium); | ||
} else if (typeof require === "function") { | ||
require(["Cesium"], startup); | ||
} | ||
</script> | ||
</body> | ||
</html> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, when darkening a color, one uses a multiply instead of a subtract. This is so that colors like bright orange
(1.0, 0.5, 0.0)
when "darkened" by 0.5 become dark orange(0.5, 0.25, 0.0)
instead of dark red(0.5, 0.0, 0.0)
.To brighten a color, you flip the effect over by subtracting from 1 before and after the multiply, like so: