Regression: sampleTerrain no longer works in NodeJS

[bkuster]

Issue

sampleTerrainMostDetailed no longer works. Error received: require is not defined.

Reasoning

require is no longer defined within an ESM module.

Reproducable

import { CesiumTerrainProvider, Cartographic, sampleTerrainMostDetailed } from "cesium";

const provider = new CesiumTerrainProvider({ url: 'https://berlin.virtualcitymap.de/datasource-data/5d2c8614-d474-442d-8975-c2b4a4c0ae94/' });
sampleTerrainMostDetailed(provider, [Cartographic.fromDegrees(0, 0)])
  .then((updated) => {
    console.log(updated);
  })
  .otherwise((err) => {
    console.error(err);
  });

Fix/Workaround

Use deferred import statements, as can be seen in this commit: virtualcitySYSTEMS@25f59d6

The question is, if cesium can support this for all its platforms? If so, I'm happy to open a PR.

[hpinkos]

Thanks for reporting this @bkuster! @ebogo1 we should look at this ASAP since it's a regression

[ebogo1]

@bkuster I am able to reproduce this issue in CesiumJS 1.73 on Node 14 and 16. Which versions of CesiumJS and Node did you notice this regression in?

[bkuster]

@ebogo1 I just stumbled across this issue today using Node 12 and cesium 1.79 (but I would assume the regression is older) while updating my module to ESM. I could also reproduce it in Node 14 & 16 (using 1.79). To verify, I then created a new package with the above code and used the latest cesium from npm & Node 14.

[ebogo1]

I don't believe there's a workaround without revisiting how we package CesiumJS for Node - this issue will happen with any file that happens to call loadWithHttpRequest in Resource.js.