Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KML ScreenOverlay Support #9862

Closed
krupkad opened this issue Oct 11, 2021 · 1 comment · Fixed by #9864
Closed

KML ScreenOverlay Support #9862

krupkad opened this issue Oct 11, 2021 · 1 comment · Fixed by #9864
Assignees

Comments

@krupkad
Copy link
Contributor

krupkad commented Oct 11, 2021

Related to / part of #873 - breaking this out since I'm actively working on this (see the screen-overlay branch).

CC @hpinkos @mramato and @IanLilleyT from preliminary discussion of this.

Seems like the easiest way to do this is to take a screenOverlayContainer in the KMLDataSource options and put images in there if it is provided, and no-op if it is not. Unsure if this handles "dynamic" overlays, which may or may not be a thing.

@krupkad krupkad self-assigned this Oct 11, 2021
@mramato
Copy link
Contributor

mramato commented Oct 11, 2021

Here is the spec for KML ScreenOverlay: https://developers.google.com/kml/documentation/kmlreference#screenoverlay

At first glance, it does look like it's possible to have a screen overlay that turns on/off or otherwise changes based on the animation time. This doesn't necessarily need to be in a MVP implementation but something we should be aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants